Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 50903009: Remove virtual where not needed in TextTrackCue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FINAL to TextTrackCueBox Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index 7fd5b9de776b7a35ef6ce218019f76ffd42753be..0326da84b8e562224701bd5256c50b42025c98a5 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -49,7 +49,7 @@ class TextTrackCue;
// ----------------------------
-class TextTrackCueBox : public HTMLDivElement {
+class TextTrackCueBox FINAL : public HTMLDivElement {
public:
static PassRefPtr<TextTrackCueBox> create(Document& document, TextTrackCue* cue)
{
@@ -57,7 +57,7 @@ public:
}
TextTrackCue* getCue() const;
- virtual void applyCSSProperties(const IntSize& videoSize);
+ void applyCSSProperties(const IntSize& videoSize);
static const AtomicString& textTrackCueBoxShadowPseudoId();
@@ -110,13 +110,13 @@ public:
void setSnapToLines(bool);
int line() const { return m_linePosition; }
- virtual void setLine(int, ExceptionState&);
+ void setLine(int, ExceptionState&);
int position() const { return m_textPosition; }
- virtual void setPosition(int, ExceptionState&);
+ void setPosition(int, ExceptionState&);
int size() const { return m_cueSize; }
- virtual void setSize(int, ExceptionState&);
+ void setSize(int, ExceptionState&);
const String& align() const;
void setAlign(const String&, ExceptionState&);
@@ -181,20 +181,12 @@ public:
};
CueAlignment getAlignment() const { return m_cueAlignment; }
- virtual void videoSizeDidChange(const IntSize&) { }
-
- virtual bool operator==(const TextTrackCue&) const;
- virtual bool operator!=(const TextTrackCue& cue) const
+ bool operator==(const TextTrackCue&) const;
+ bool operator!=(const TextTrackCue& cue) const
{
return !(*this == cue);
}
- enum CueType {
- Generic,
- WebVTT
- };
- virtual CueType cueType() const { return WebVTT; }
-
DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698