Remove virtual where not needed in TextTrackCue

Source/core/html/track/TextTrackCue.h

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2012, 2013 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 31 matching lines @@
 
 class Document;
 class DocumentFragment;
 class ExceptionState;
 class ExecutionContext;
 class TextTrack;
 class TextTrackCue;
 
 // ----------------------------
 
 class TextTrackCueBox : public HTMLDivElement {

[vcarbune.chromium, 2013/11/01 09:55:37]

Add FINAL to TextTrackCueBox ?

[philipj_slow, 2013/11/01 11:39:26]

Done.

 public:
     static PassRefPtr<TextTrackCueBox> create(Document& document, TextTrackCue* cue)
     {
         return adoptRef(new TextTrackCueBox(document, cue));
     }
 
     TextTrackCue* getCue() const;
-    virtual void applyCSSProperties(const IntSize& videoSize);
+    void applyCSSProperties(const IntSize& videoSize);
 
     static const AtomicString& textTrackCueBoxShadowPseudoId();
 
 protected:
     TextTrackCueBox(Document&, TextTrackCue*);
 
     virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;
 
     TextTrackCue* m_cue;
 };
@@ skipping 32 matching lines @@
     bool pauseOnExit() const { return m_pauseOnExit; }
     void setPauseOnExit(bool);
 
     const String& vertical() const;
     void setVertical(const String&, ExceptionState&);
 
     bool snapToLines() const { return m_snapToLines; }
     void setSnapToLines(bool);
 
     int line() const { return m_linePosition; }
-    virtual void setLine(int, ExceptionState&);
+    void setLine(int, ExceptionState&);
 
     int position() const { return m_textPosition; }
-    virtual void setPosition(int, ExceptionState&);
+    void setPosition(int, ExceptionState&);
 
     int size() const { return m_cueSize; }
-    virtual void setSize(int, ExceptionState&);
+    void setSize(int, ExceptionState&);
 
     const String& align() const;
     void setAlign(const String&, ExceptionState&);
 
     const String& text() const { return m_content; }
     void setText(const String&);
 
     const String& cueSettings() const { return m_settings; }
     void setCueSettings(const String&);
 
@@ skipping 44 matching lines @@
     enum CueAlignment {
         Start = 0,
         Middle,
         End,
         Left,
         Right,
         NumberOfAlignments
     };
     CueAlignment getAlignment() const { return m_cueAlignment; }
 
-    virtual void videoSizeDidChange(const IntSize&) { }
-
-    virtual bool operator==(const TextTrackCue&) const;
-    virtual bool operator!=(const TextTrackCue& cue) const
+    bool operator==(const TextTrackCue&) const;
+    bool operator!=(const TextTrackCue& cue) const
     {
         return !(*this == cue);
     }
 
-    enum CueType {
-        Generic,
-        WebVTT
-    };
-    virtual CueType cueType() const { return WebVTT; }
-
     DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
 
 private:
     TextTrackCue(Document&, double start, double end, const String& content);
 
     Document& document() const;
 
     PassRefPtr<TextTrackCueBox> displayTreeInternal();
 
@@ skipping 52 matching lines @@
     int m_displaySize;
 
     std::pair<float, float> m_displayPosition;
     String m_regionId;
     bool m_notifyRegion;
 };
 
 } // namespace WebCore
 
 #endif