Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: Source/core/html/shadow/MediaControlElements.cpp

Issue 50903009: Remove virtual where not needed in TextTrackCue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FINAL to TextTrackCueBox Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 return; 785 return;
786 m_videoDisplaySize = videoBox; 786 m_videoDisplaySize = videoBox;
787 787
788 float smallestDimension = std::min(m_videoDisplaySize.size().height(), m_vid eoDisplaySize.size().width()); 788 float smallestDimension = std::min(m_videoDisplaySize.size().height(), m_vid eoDisplaySize.size().width());
789 789
790 float fontSize = smallestDimension * 0.05f; 790 float fontSize = smallestDimension * 0.05f;
791 if (fontSize != m_fontSize) { 791 if (fontSize != m_fontSize) {
792 m_fontSize = fontSize; 792 m_fontSize = fontSize;
793 setInlineStyleProperty(CSSPropertyFontSize, fontSize, CSSPrimitiveValue: :CSS_PX); 793 setInlineStyleProperty(CSSPropertyFontSize, fontSize, CSSPrimitiveValue: :CSS_PX);
794 } 794 }
795
796 CueList activeCues = mediaElement->currentlyActiveCues();
797 for (size_t i = 0; i < activeCues.size(); ++i) {
798 TextTrackCue* cue = activeCues[i].data();
799 cue->videoSizeDidChange(m_videoDisplaySize.size());
800 }
801 } 795 }
802 796
803 // ---------------------------- 797 // ----------------------------
804 798
805 } // namespace WebCore 799 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698