Update old syntax for action default_icon to populate 19 and 38px icons

Update old syntax for action default_icon to populate 19 and 38px icons

BUG=404572
Committed: https://crrev.com/f3f3ce763f95833d59b47e2ebd48537cc1bf24b7
Cr-Commit-Position: refs/heads/master@{#292236}

[gpdavis, 2014-08-26 22:06:19]

gpdavis.chromium@gmail.com changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2014-08-26 22:25:41]

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/extension_action/action_info.cc (right):

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/extension_action/action_info.cc:106: default_icon);
The default icon logic will automatically scale down
(extension_misc::EXTENSION_ICON_ACTION * 2) to
extension_misc::EXTENSION_ICON_ACTION, right? So you shouldn't even need this
first case anymore.

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/intros/browserAction.html (right):

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/browserAction.html:56: <em>//
equivalent to "default_icon": { "19": "images/icon19.png", "38":
"images/icon19.png" }</em>
Just update the 19 to 38 in this example, i.e. icon38.png, equivalent to "38":
.. etc.

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/browserAction.html:165: the
19x19-pixel space.
Mind changing this to 38x38?

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/intros/pageAction.html (right):

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/pageAction.html:61: <em>//
equivalent to "default_icon": { "19": "images/icon19.png", "38":
"images/icon19.png" }</em>
ditto

[gpdavis, 2014-08-26 23:24:43]

Anything else we ought to address here?

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/extension_action/action_info.cc (right):

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/extension_action/action_info.cc:106: default_icon);
On 2014/08/26 22:25:41, kalman wrote:
> The default icon logic will automatically scale down
> (extension_misc::EXTENSION_ICON_ACTION * 2) to
> extension_misc::EXTENSION_ICON_ACTION, right? So you shouldn't even need this
> first case anymore.

Done.

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/intros/browserAction.html (right):

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/browserAction.html:56: <em>//
equivalent to "default_icon": { "19": "images/icon19.png", "38":
"images/icon19.png" }</em>
On 2014/08/26 22:25:41, kalman wrote:
> Just update the 19 to 38 in this example, i.e. icon38.png, equivalent to "38":
> .. etc.

Done.

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/browserAction.html:165: the
19x19-pixel space.
On 2014/08/26 22:25:41, kalman wrote:
> Mind changing this to 38x38?

Done.

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/intros/pageAction.html (right):

https://codereview.chromium.org/508783002/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/pageAction.html:61: <em>//
equivalent to "default_icon": { "19": "images/icon19.png", "38":
"images/icon19.png" }</em>
On 2014/08/26 22:25:41, kalman wrote:
> ditto

Done.

[not at google - send to devlin, 2014-08-27 01:11:35]

lgtm

https://codereview.chromium.org/508783002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/extension_action/action_info.cc (right):

https://codereview.chromium.org/508783002/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/extension_action/action_info.cc:105:
result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION * 2,
Actually this should be multiplying by
extension_misc::kNumExtensionActionIconSizes, not 2. And you should add a
comment:

// Choose the most optimistic (highest) icon density - e.g. 38 not 19 -
regardless of the actual icon resolution, whatever that happens to be. Code
elsewhere knows how to scale 38 down to 19.

[gpdavis, 2014-08-27 17:46:23]

Patchset #4 (id:60001) has been deleted

[gpdavis, 2014-08-27 17:53:51]

The CQ bit was checked by gpdavis.chromium@gmail.com

[commit-bot: I haz the power, 2014-08-27 17:55:12]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/508783002/8...

[commit-bot: I haz the power, 2014-08-27 18:53:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 19:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 19:21:26]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gpdavis, 2014-08-27 20:48:46]

The CQ bit was checked by gpdavis.chromium@gmail.com

[commit-bot: I haz the power, 2014-08-27 20:50:22]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/508783002/1...

[commit-bot: I haz the power, 2014-08-27 21:56:45]

Committed patchset #5 (id:100001) as f1f83a89b01594df5707528755fe05adb8d6d488

[commit-bot: I haz the power, 2014-09-10 02:54:31]

Patchset 5 (id:??) landed as
https://crrev.com/f3f3ce763f95833d59b47e2ebd48537cc1bf24b7
Cr-Commit-Position: refs/heads/master@{#292236}