chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc - Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated unit test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | chrome/common/extensions/docs/templates/intros/browserAction.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

index af73d5b769718c44e3115bba3df12e558fe52020..f69ae147fa25a0a559ab792038bd0fc3a9a601c3 100644

--- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

@@ -60,7 +60,7 @@ TEST_F(BrowserActionManifestTest,

const ExtensionIconSet& icons = browser_action_info->default_icon;

EXPECT_EQ(1u, icons.map().size());

- EXPECT_EQ("icon.png", icons.Get(19, ExtensionIconSet::MATCH_EXACTLY));

+ EXPECT_EQ("icon.png", icons.Get(38, ExtensionIconSet::MATCH_EXACTLY));

}

TEST_F(BrowserActionManifestTest,