chrome/common/extensions/docs/templates/intros/browserAction.html - Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/templates/intros/browserAction.html

Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated unit test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc ('k') | chrome/common/extensions/docs/templates/intros/pageAction.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/templates/intros/browserAction.html

diff --git a/chrome/common/extensions/docs/templates/intros/browserAction.html b/chrome/common/extensions/docs/templates/intros/browserAction.html

index 96c02dd959121d907cd04efbc21ed974f25cc706..d7f93cf4540b4d1d1f4a83f42ed71c5df7f65c81 100644

--- a/chrome/common/extensions/docs/templates/intros/browserAction.html

+++ b/chrome/common/extensions/docs/templates/intros/browserAction.html

@@ -52,8 +52,8 @@ default icon is still supported:

...

"browser_action": {

...

- "default_icon": "images/icon19.png" // optional

- // equivalent to "default_icon": { "19": "images/icon19.png" }

+ "default_icon": "images/icon38.png" // optional

+ // equivalent to "default_icon": { "38": "images/icon38.png" }

},

...

}

@@ -162,7 +162,7 @@ $(ref:browserAction.setPopup) method.

that make sense for only a few pages.

Use <a href="pageAction">page actions</a> instead.

<li>Do use big, colorful icons that make the most of

- the 19x19-pixel space.

+ the 38x38-pixel space.

Browser action icons should seem a little bigger

and heavier than page action icons.

<li>Don't attempt to mimic