Update old syntax for action default_icon to populate 19 and 38px icons

chrome/common/extensions/api/extension_action/action_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/extensions/api/commands/commands_handler.h"
 #include "extensions/common/constants.h"
@@ skipping 84 matching lines @@
               icons_value,
               extension_misc::kExtensionActionIconSizes,
               extension_misc::kNumExtensionActionIconSizes,
               &result->default_icon,
               error)) {
         return scoped_ptr<ActionInfo>();
       }
     } else if (dict->GetString(keys::kPageActionDefaultIcon, &default_icon) &&
                manifest_handler_helpers::NormalizeAndValidatePath(
                    &default_icon)) {
-      result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION,
+      result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION * 2,

[not at google - send to devlin, 2014/08/27 01:11:35]

Actually this should be multiplying by
extension_misc::kNumExtensionActionIconSizes, not 2. And you should add a
comment:

// Choose the most optimistic (highest) icon density - e.g. 38 not 19 -
regardless of the actual icon resolution, whatever that happens to be. Code
elsewhere knows how to scale 38 down to 19.

                                default_icon);
     } else {
       *error = base::ASCIIToUTF16(errors::kInvalidPageActionIconPath);
       return scoped_ptr<ActionInfo>();
     }
   }
 
   // Read the page action title from |default_title| if present, |name| if not
   // (both optional).
   if (dict->HasKey(keys::kPageActionDefaultTitle)) {
@@ skipping 97 matching lines @@
 
 // static
 bool ActionInfo::IsVerboseInstallMessage(const Extension* extension) {
   const ActionInfo* page_action_info = GetPageActionInfo(extension);
   return page_action_info &&
       (CommandsInfo::GetPageActionCommand(extension) ||
        !page_action_info->default_icon.empty());
 }
 
 }  // namespace extensions