Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: chrome/common/extensions/docs/templates/intros/pageAction.html

Issue 508783002: Update old syntax for action default_icon to populate 19 and 38px icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated unit test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/templates/intros/browserAction.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/templates/intros/pageAction.html
diff --git a/chrome/common/extensions/docs/templates/intros/pageAction.html b/chrome/common/extensions/docs/templates/intros/pageAction.html
index 278df74ebb2123d4e8824cb9ad25a692dab42453..d547e21cfc135f748ffc092ad6f6cbe68cd29673 100644
--- a/chrome/common/extensions/docs/templates/intros/pageAction.html
+++ b/chrome/common/extensions/docs/templates/intros/pageAction.html
@@ -57,8 +57,8 @@ default icon is still supported:
...
<b>"page_action": {
...
- "default_icon": "images/icon19.png" <em>// optional</em>
- <em>// equivalent to "default_icon": { "19": "images/icon19.png" }</em>
+ "default_icon": "images/icon38.png" <em>// optional</em>
+ <em>// equivalent to "default_icon": { "38": "images/icon38.png" }</em>
}</b>,
...
}</pre>
« no previous file with comments | « chrome/common/extensions/docs/templates/intros/browserAction.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698