Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508283002: Revert "Typecheck JS files for chrome://extensions" (Closed)

Created:
6 years, 3 months ago by eroman
Modified:
6 years, 3 months ago
Reviewers:
Vitaly Pavlenko
CC:
chromium-reviews, extensions-reviews_chromium.org, dcheng, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/069e64df9c70919d3e242504b1c54c20632d703e Cr-Commit-Position: refs/heads/master@{#292208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -364 lines) Patch
M chrome/browser/resources/extensions/chromeos/kiosk_app_list.js View 3 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/resources/extensions/compiled_resources.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/resources/extensions/extension_code.js View 2 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/resources/extensions/extension_command_list.js View 14 chunks +13 lines, -24 lines 0 comments Download
M chrome/browser/resources/extensions/extension_commands_overlay.js View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/extensions/extension_error.js View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/extensions/extension_error_overlay.js View 17 chunks +35 lines, -65 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 5 chunks +4 lines, -58 lines 0 comments Download
M chrome/browser/resources/extensions/extension_loader.js View 7 chunks +15 lines, -22 lines 0 comments Download
M chrome/browser/resources/extensions/extension_options_overlay.js View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 5 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/resources/extensions/pack_extension_overlay.js View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/browser/extension_error.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/webui/resources/js/cr/event_target.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/alert_overlay.js View 2 chunks +15 lines, -15 lines 0 comments Download
M ui/webui/resources/js/cr/ui/array_data_model.js View 9 chunks +13 lines, -18 lines 0 comments Download
M ui/webui/resources/js/cr/ui/drag_wrapper.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/grid.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list.js View 14 chunks +31 lines, -32 lines 0 comments Download
M ui/webui/resources/js/cr/ui/list_item.js View 3 chunks +4 lines, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/list_selection_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/list_selection_model.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
eroman@chromium.org changed reviewers: + vitalyp@chromium.org
6 years, 3 months ago (2014-08-27 19:52:52 UTC) #1
eroman
6 years, 3 months ago (2014-08-27 19:52:52 UTC) #2
eroman
Committed patchset #1 (id:1) to pending queue manually as 87b3206.
6 years, 3 months ago (2014-08-27 19:56:20 UTC) #3
Dan Beam
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/512003002/ by dbeam@chromium.org. The ...
6 years, 3 months ago (2014-08-27 21:25:39 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:33 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/069e64df9c70919d3e242504b1c54c20632d703e
Cr-Commit-Position: refs/heads/master@{#292208}

Powered by Google App Engine
This is Rietveld 408576698