Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: ui/webui/resources/js/cr/ui/alert_overlay.js

Issue 508283002: Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/cr/event_target.js ('k') | ui/webui/resources/js/cr/ui/array_data_model.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/cr/ui/alert_overlay.js
diff --git a/ui/webui/resources/js/cr/ui/alert_overlay.js b/ui/webui/resources/js/cr/ui/alert_overlay.js
index 062f5b3fceb81f6502379ab6f255cc526c1f09a1..7a54d4395e856c6d94a7514b7ef71760d9274113 100644
--- a/ui/webui/resources/js/cr/ui/alert_overlay.js
+++ b/ui/webui/resources/js/cr/ui/alert_overlay.js
@@ -42,18 +42,18 @@ cr.define('alertOverlay', function() {
* callbacks.
* @param {string} title The alert title to display to the user.
* @param {string} message The alert message to display to the user.
- * @param {string=} opt_okTitle The title of the OK button. If undefined or
- * empty, no button is shown.
- * @param {string=} opt_cancelTitle The title of the cancel button. If
- * undefined or empty, no button is shown.
+ * @param {string=} okTitle The title of the OK button. If undefined or empty,
+ * no button is shown.
+ * @param {string=} cancelTitle The title of the cancel button. If undefined
+ * or empty, no button is shown.
* @param {function()=} opt_okCallback A function to be called when the user
- * presses the ok button. Can be undefined if |opt_okTitle| is falsey.
+ * presses the ok button. Can be undefined if |okTitle| is falsey.
* @param {function()=} opt_cancelCallback A function to be called when the
- * user presses the cancel button. Can be undefined if |opt_cancelTitle|
- * is falsey.
+ * user presses the cancel button. Can be undefined if |cancelTitle| is
+ * falsey.
*/
- function setValues(title, message, opt_okTitle, opt_cancelTitle,
- opt_okCallback, opt_cancelCallback) {
+ function setValues(title, message, okTitle, cancelTitle, opt_okCallback,
+ opt_cancelCallback) {
if (typeof title != 'undefined')
$('alertOverlayTitle').textContent = title;
$('alertOverlayTitle').hidden = typeof title == 'undefined';
@@ -62,14 +62,14 @@ cr.define('alertOverlay', function() {
$('alertOverlayMessage').textContent = message;
$('alertOverlayMessage').hidden = typeof message == 'undefined';
- if (opt_okTitle)
- okButton.textContent = opt_okTitle;
- okButton.hidden = !opt_okTitle;
+ if (okTitle)
+ okButton.textContent = okTitle;
+ okButton.hidden = !okTitle;
okButton.clickCallback = opt_okCallback;
- if (opt_cancelTitle)
- cancelButton.textContent = opt_cancelTitle;
- cancelButton.hidden = !opt_cancelTitle;
+ if (cancelTitle)
+ cancelButton.textContent = cancelTitle;
+ cancelButton.hidden = !cancelTitle;
cancelButton.clickCallback = opt_cancelCallback;
};
« no previous file with comments | « ui/webui/resources/js/cr/event_target.js ('k') | ui/webui/resources/js/cr/ui/array_data_model.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698