Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 508283002: Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 3b929f7115f7dc7392ea5030e166c08a732aa6c2..fa8d7f02ddc0c11cfdd3664505d1ed3f52cf1ffa 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -5,10 +5,10 @@
<include src="../uber/uber_utils.js">
<include src="extension_code.js">
<include src="extension_commands_overlay.js">
-<include src="extension_error_overlay.js">
<include src="extension_focus_manager.js">
<include src="extension_list.js">
<include src="pack_extension_overlay.js">
+<include src="extension_error_overlay.js">
<include src="extension_loader.js">
<include src="extension_options_overlay.js">
@@ -16,19 +16,6 @@
<include src="chromeos/kiosk_apps.js">
</if>
-/**
- * The type of the extension data object. The definition is based on
- * chrome/browser/ui/webui/extensions/extension_settings_handler.cc:
- * ExtensionSettingsHandler::HandleRequestExtensionsData()
- * @typedef {{developerMode: boolean,
- * extensions: Array,
- * incognitoAvailable: boolean,
- * loadUnpackedDisabled: boolean,
- * profileIsSupervised: boolean,
- * promoteAppsDevTools: boolean}}
- */
-var ExtensionDataResponse;
-
// Used for observing function of the backend datasource for this page by
// tests.
var webuiResponded = false;
@@ -272,7 +259,7 @@ cr.define('extensions', function() {
} else {
$('extension-settings').classList.remove('dev-mode');
}
- window.setTimeout(this.updatePromoVisibility_.bind(this), 0);
+ window.setTimeout(this.updatePromoVisibility_.bind(this));
chrome.send('extensionSettingsToggleDeveloperMode');
},
@@ -293,7 +280,6 @@ cr.define('extensions', function() {
/**
* Called by the dom_ui_ to re-populate the page with data representing
* the current state of installed extensions.
- * @param {ExtensionDataResponse} extensionsData
*/
ExtensionSettings.returnExtensionsData = function(extensionsData) {
// We can get called many times in short order, thus we need to
@@ -417,7 +403,7 @@ cr.define('extensions', function() {
pages[i].setAttribute('aria-hidden', node ? 'true' : 'false');
}
- $('overlay').hidden = !node;
+ overlay.hidden = !node;
uber.invokeMethodOnParent(node ? 'beginInterceptingEvents' :
'stopInterceptingEvents');
};

Powered by Google App Engine
This is Rietveld 408576698