extensions/browser/extension_error.cc - Issue 508283002: Revert "Typecheck JS files for chrome://extensions"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_error.cc

Issue 508283002: Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_error.cc

diff --git a/extensions/browser/extension_error.cc b/extensions/browser/extension_error.cc

index 19a31ea9ed529a6fdce9da60559bd23a6a09f17e..d8733fe51dc0234222f57984b487615512137855 100644

--- a/extensions/browser/extension_error.cc

+++ b/extensions/browser/extension_error.cc

@@ -158,10 +158,6 @@ RuntimeError::~RuntimeError() {

}

scoped_ptr<DictionaryValue> RuntimeError::ToValue() const {

- // The items which are to be written into value are also described in

- // chrome/browser/resources/extensions/extension_error_overlay.js in @typedef

- // for RuntimeError and StackTrace. Please update them whenever you add or

- // remove any keys here.

scoped_ptr<DictionaryValue> value = ExtensionError::ToValue();

value->SetString(kContextUrlKey, context_url_.spec());

value->SetInteger(kRenderViewIdKey, render_view_id_);