Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2530)

Unified Diff: chrome/browser/resources/extensions/pack_extension_overlay.js

Issue 508283002: Revert "Typecheck JS files for chrome://extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/pack_extension_overlay.js
diff --git a/chrome/browser/resources/extensions/pack_extension_overlay.js b/chrome/browser/resources/extensions/pack_extension_overlay.js
index 186f84102e632463ca50099b89a95438d9c8c4b9..22a316501525994545f0585d458331f709dd9408 100644
--- a/chrome/browser/resources/extensions/pack_extension_overlay.js
+++ b/chrome/browser/resources/extensions/pack_extension_overlay.js
@@ -60,9 +60,9 @@ cr.define('extensions', function() {
* @private
*/
showFileDialog_: function(selectType, operation, callback) {
- window.handleFilePathSelected = function(filePath) {
+ handleFilePathSelected = function(filePath) {
callback(filePath);
- window.handleFilePathSelected = function() {};
+ handleFilePathSelected = function() {};
};
chrome.send('packExtensionSelectFilePath', [selectType, operation]);
@@ -104,14 +104,14 @@ cr.define('extensions', function() {
'',
function() {
extensions.ExtensionSettings.showOverlay(null);
- });
+ },
+ null);
extensions.ExtensionSettings.showOverlay($('alertOverlay'));
};
/**
* Post an alert overlay showing |message|, and upon acknowledgement, close
* the alert overlay and return to showing the PackExtensionOverlay.
- * @param {string} message The error message.
*/
PackExtensionOverlay.showError = function(message) {
alertOverlay.setValues(
@@ -121,7 +121,8 @@ cr.define('extensions', function() {
'',
function() {
extensions.ExtensionSettings.showOverlay($('pack-extension-overlay'));
- });
+ },
+ null);
extensions.ExtensionSettings.showOverlay($('alertOverlay'));
};
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698