Remove implicit conversions from scoped_refptr to T* in cc/

Remove implicit conversions from scoped_refptr to T* in cc/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
Committed: https://crrev.com/80bc5e3ce73e2a306bec3aca8aa4d54b66b95d04
Cr-Commit-Position: refs/heads/master@{#291833}

[dcheng, 2014-08-25 23:24:07]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[dcheng, 2014-08-25 23:24:07]

Note: this is the remainder of cc outside cc/trees.

Unfortunately, we can't make scoped_refptr testable until the conversion
operator has been removed. While it would be possible to disable the conversion
operator and make it testable in the same patch, the automated tool tries to
skip rewriting code where manual cleanups would be useful. This includes things
like:

// What if ReturnsScopedRefPtr() creates a new object internally?
if (ReturnsScopedRefPtr())

Foo* Bar() {
  const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
  return f;  // Does the return type need to be rewritten? Or is .get() safe?
}

Doing this in one patch would make catching some of these instances (in
particular, a boolean test on a temporary scoped_refptr) more difficult. As a
result, the work is being split into several steps:
Step 1: Rewrite all implicit conversions to be explicit (or rewrite the receiver
type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
Step 2: Once a platform compiles cleanly without the conversion operator, #ifdef
the conversion operator out.
Step 3: Make scoped_refptr testable on that platform.
Step 4: Remove unnecessary calls to .get().

[enne (OOO), 2014-08-25 23:39:12]

lgtm, except:

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider.cc (left):

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:2269: ContextProvider* context_provider =
output_surface_->context_provider();
This is a local alias, not an ownership transfer.  No need for this
scoped_refptr.

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:2269: ContextProvider* context_provider =
output_surface_->context_provider();
Same here.

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:2264: scoped_refptr<ContextProvider>
context_provider =
This is a local alias, not an ownership transfer.  No need for this
scoped_refptr.

[dcheng, 2014-08-25 23:44:56]

Oops. This is the 'assigning a temporary scoped_refptr to a T*' logic kicking
in, in case the assignment is unsafe. I've been spot checking patches to revert
instances where it turns out to be unnecessary but I missed this one. Thanks for
catching these.

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider.cc (left):

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:2269: ContextProvider* context_provider =
output_surface_->context_provider();
On 2014/08/25 23:39:12, enne wrote:
> Same here.

Done.

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/502203003/diff/1/cc/resources/resource_provid...
cc/resources/resource_provider.cc:2264: scoped_refptr<ContextProvider>
context_provider =
On 2014/08/25 23:39:12, enne wrote:
> This is a local alias, not an ownership transfer.  No need for this
> scoped_refptr.

Done.

[dcheng, 2014-08-25 23:45:05]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-25 23:48:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/502203003/20001

[commit-bot: I haz the power, 2014-08-26 01:37:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-26 02:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 02:45:55]

Failed to commit the patch.

[dcheng, 2014-08-26 03:51:59]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 03:52:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/502203003/20001

[commit-bot: I haz the power, 2014-08-26 03:54:26]

Committed patchset #2 (20001) as 3cb9945823cb110ac837a77c124a4e0725a3578d

[commit-bot: I haz the power, 2014-09-10 02:40:13]

Patchset 2 (id:??) landed as
https://crrev.com/80bc5e3ce73e2a306bec3aca8aa4d54b66b95d04
Cr-Commit-Position: refs/heads/master@{#291833}