Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3545)

Unified Diff: cc/output/renderer_pixeltest.cc

Issue 502203003: Remove implicit conversions from scoped_refptr to T* in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change to use .get() instead of rewriting local variable Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/output_surface.cc ('k') | cc/output/renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/renderer_pixeltest.cc
diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc
index a22540db3f69837ffb0a2514220be4efb2b039b1..42ab695b27b4aca07612e5c0ea1d6e5de19060ce 100644
--- a/cc/output/renderer_pixeltest.cc
+++ b/cc/output/renderer_pixeltest.cc
@@ -1769,7 +1769,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadIdentityScale) {
texture_format,
viewport,
1.f,
- PicturePileImpl::CreateFromOther(blue_pile));
+ PicturePileImpl::CreateFromOther(blue_pile.get()));
// One viewport-filling green quad.
scoped_refptr<FakePicturePileImpl> green_pile =
@@ -1794,7 +1794,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadIdentityScale) {
texture_format,
viewport,
1.f,
- PicturePileImpl::CreateFromOther(green_pile));
+ PicturePileImpl::CreateFromOther(green_pile.get()));
RenderPassList pass_list;
pass_list.push_back(pass.Pass());
@@ -1840,7 +1840,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadOpacity) {
texture_format,
viewport,
1.f,
- PicturePileImpl::CreateFromOther(green_pile));
+ PicturePileImpl::CreateFromOther(green_pile.get()));
// One viewport-filling white quad.
scoped_refptr<FakePicturePileImpl> white_pile =
@@ -1865,7 +1865,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadOpacity) {
texture_format,
viewport,
1.f,
- PicturePileImpl::CreateFromOther(white_pile));
+ PicturePileImpl::CreateFromOther(white_pile.get()));
RenderPassList pass_list;
pass_list.push_back(pass.Pass());
@@ -1939,7 +1939,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadDisableImageFiltering) {
texture_format,
viewport,
1.f,
- PicturePileImpl::CreateFromOther(pile));
+ PicturePileImpl::CreateFromOther(pile.get()));
RenderPassList pass_list;
pass_list.push_back(pass.Pass());
@@ -1996,7 +1996,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadNonIdentityScale) {
texture_format,
green_rect1,
1.f,
- PicturePileImpl::CreateFromOther(green_pile));
+ PicturePileImpl::CreateFromOther(green_pile.get()));
PictureDrawQuad* green_quad2 =
pass->CreateAndAppendDrawQuad<PictureDrawQuad>();
@@ -2009,7 +2009,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadNonIdentityScale) {
texture_format,
green_rect2,
1.f,
- PicturePileImpl::CreateFromOther(green_pile));
+ PicturePileImpl::CreateFromOther(green_pile.get()));
// Add a green clipped checkerboard in the bottom right to help test
// interleaving picture quad content and solid color content.
@@ -2084,7 +2084,7 @@ TYPED_TEST(RendererPixelTest, PictureDrawQuadNonIdentityScale) {
texture_format,
content_union_rect,
contents_scale,
- PicturePileImpl::CreateFromOther(pile));
+ PicturePileImpl::CreateFromOther(pile.get()));
// Fill left half of viewport with green.
gfx::Transform half_green_content_to_target_transform;
@@ -2140,7 +2140,7 @@ TEST_F(GLRendererPixelTest, PictureDrawQuadTexture4444) {
texture_format,
viewport,
1.f,
- PicturePileImpl::CreateFromOther(blue_pile));
+ PicturePileImpl::CreateFromOther(blue_pile.get()));
RenderPassList pass_list;
pass_list.push_back(pass.Pass());
« no previous file with comments | « cc/output/output_surface.cc ('k') | cc/output/renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698