Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 48803004: Have Document::nodeWillBeRemoved() take a reference (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have Document::nodeWillBeRemoved() take a reference Have Document::nodeWillBeRemoved() take a reference instead of a pointer as it can never be null. This makes the caller simpler as it already have a Node reference. This also gets rid of several unnecessary null checks. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -59 lines) Patch
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/NodeIterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 2 chunks +13 lines, -14 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M Source/core/dom/RangeBoundaryPoint.h View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/editing/Caret.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Caret.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-10-30 21:19:57 UTC) #1
adamk
lgtm
7 years, 1 month ago (2013-10-30 22:22:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/48803004/1
7 years, 1 month ago (2013-10-30 22:46:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/48803004/1
7 years, 1 month ago (2013-10-30 22:59:14 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 23:52:38 UTC) #5
Message was sent while issue was closed.
Change committed as 160986

Powered by Google App Engine
This is Rietveld 408576698