Source/core/editing/Caret.h - Issue 48803004: Have Document::nodeWillBeRemoved() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Caret.h

Issue 48803004: Have Document::nodeWillBeRemoved() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/Caret.h

diff --git a/Source/core/editing/Caret.h b/Source/core/editing/Caret.h

index 02eb02fdb9b981e050503e84ff7e3d032831ed6f..18c74218038e026085ee5d99600763684030a632 100644

--- a/Source/core/editing/Caret.h

+++ b/Source/core/editing/Caret.h

@@ -88,7 +88,7 @@ public:

void setCaretPosition(const VisiblePosition&);

void clear() { setCaretPosition(VisiblePosition()); }

- void nodeWillBeRemoved(Node*);

+ void nodeWillBeRemoved(Node&);

private:

DragCaretController();

« no previous file with comments | « Source/core/dom/RangeBoundaryPoint.h ('k') | Source/core/editing/Caret.cpp » ('j') | no next file with comments »