Source/core/page/EventHandler.cpp - Issue 48803004: Have Document::nodeWillBeRemoved() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 48803004: Have Document::nodeWillBeRemoved() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index ec9ef828bde0efc37145e99e28428bd4c3f033ac..a0ab1e1961e1c048c0f4d6529f8ccd5e017b86e8 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -364,9 +364,9 @@ void EventHandler::clear()

m_mouseDownMayStartDrag = false;

}

-void EventHandler::nodeWillBeRemoved(Node* nodeToBeRemoved)

+void EventHandler::nodeWillBeRemoved(Node& nodeToBeRemoved)

{

- if (nodeToBeRemoved->contains(m_clickNode.get()))

+ if (nodeToBeRemoved.contains(m_clickNode.get()))

m_clickNode = 0;

}

« no previous file with comments | « Source/core/page/EventHandler.h ('k') | no next file » | no next file with comments »