Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: Source/core/dom/Document.h

Issue 48803004: Have Document::nodeWillBeRemoved() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 void detachNodeIterator(NodeIterator*); 641 void detachNodeIterator(NodeIterator*);
642 void moveNodeIteratorsToNewDocument(Node*, Document*); 642 void moveNodeIteratorsToNewDocument(Node*, Document*);
643 643
644 void attachRange(Range*); 644 void attachRange(Range*);
645 void detachRange(Range*); 645 void detachRange(Range*);
646 646
647 void updateRangesAfterChildrenChanged(ContainerNode*); 647 void updateRangesAfterChildrenChanged(ContainerNode*);
648 // nodeChildrenWillBeRemoved is used when removing all node children at once . 648 // nodeChildrenWillBeRemoved is used when removing all node children at once .
649 void nodeChildrenWillBeRemoved(ContainerNode*); 649 void nodeChildrenWillBeRemoved(ContainerNode*);
650 // nodeWillBeRemoved is only safe when removing one node at a time. 650 // nodeWillBeRemoved is only safe when removing one node at a time.
651 void nodeWillBeRemoved(Node*); 651 void nodeWillBeRemoved(Node&);
652 bool canReplaceChild(Node* newChild, Node* oldChild); 652 bool canReplaceChild(Node* newChild, Node* oldChild);
653 653
654 void didInsertText(Node*, unsigned offset, unsigned length); 654 void didInsertText(Node*, unsigned offset, unsigned length);
655 void didRemoveText(Node*, unsigned offset, unsigned length); 655 void didRemoveText(Node*, unsigned offset, unsigned length);
656 void didMergeTextNodes(Text* oldNode, unsigned offset); 656 void didMergeTextNodes(Text* oldNode, unsigned offset);
657 void didSplitTextNode(Text* oldNode); 657 void didSplitTextNode(Text* oldNode);
658 658
659 void clearDOMWindow() { m_domWindow = 0; } 659 void clearDOMWindow() { m_domWindow = 0; }
660 DOMWindow* domWindow() const { return m_domWindow; } 660 DOMWindow* domWindow() const { return m_domWindow; }
661 661
(...skipping 714 matching lines...) Expand 10 before | Expand all | Expand 10 after
1376 inline bool Node::isDocumentNode() const 1376 inline bool Node::isDocumentNode() const
1377 { 1377 {
1378 return this == documentInternal(); 1378 return this == documentInternal();
1379 } 1379 }
1380 1380
1381 Node* eventTargetNodeForDocument(Document*); 1381 Node* eventTargetNodeForDocument(Document*);
1382 1382
1383 } // namespace WebCore 1383 } // namespace WebCore
1384 1384
1385 #endif // Document_h 1385 #endif // Document_h
OLDNEW
« no previous file with comments | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698