Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 48803004: Have Document::nodeWillBeRemoved() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/NodeIterator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3480 matching lines...) Expand 10 before | Expand all | Expand 10 after
3491 NoEventDispatchAssertion assertNoEventDispatch; 3491 NoEventDispatchAssertion assertNoEventDispatch;
3492 if (!m_ranges.isEmpty()) { 3492 if (!m_ranges.isEmpty()) {
3493 HashSet<Range*>::const_iterator end = m_ranges.end(); 3493 HashSet<Range*>::const_iterator end = m_ranges.end();
3494 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it) 3494 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it)
3495 (*it)->nodeChildrenWillBeRemoved(container); 3495 (*it)->nodeChildrenWillBeRemoved(container);
3496 } 3496 }
3497 3497
3498 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d(); 3498 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d();
3499 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) { 3499 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) {
3500 for (Node* n = container->firstChild(); n; n = n->nextSibling()) 3500 for (Node* n = container->firstChild(); n; n = n->nextSibling())
3501 (*it)->nodeWillBeRemoved(n); 3501 (*it)->nodeWillBeRemoved(*n);
3502 } 3502 }
3503 3503
3504 if (Frame* frame = this->frame()) { 3504 if (Frame* frame = this->frame()) {
3505 for (Node* n = container->firstChild(); n; n = n->nextSibling()) { 3505 for (Node* n = container->firstChild(); n; n = n->nextSibling()) {
3506 frame->eventHandler().nodeWillBeRemoved(n); 3506 frame->eventHandler().nodeWillBeRemoved(*n);
3507 frame->selection().nodeWillBeRemoved(n); 3507 frame->selection().nodeWillBeRemoved(*n);
3508 frame->page()->dragCaretController().nodeWillBeRemoved(n); 3508 frame->page()->dragCaretController().nodeWillBeRemoved(*n);
3509 } 3509 }
3510 } 3510 }
3511 } 3511 }
3512 3512
3513 void Document::nodeWillBeRemoved(Node* n) 3513 void Document::nodeWillBeRemoved(Node& n)
3514 { 3514 {
3515 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d(); 3515 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d();
3516 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) 3516 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it)
3517 (*it)->nodeWillBeRemoved(n); 3517 (*it)->nodeWillBeRemoved(n);
3518 3518
3519 if (!m_ranges.isEmpty()) { 3519 if (!m_ranges.isEmpty()) {
3520 HashSet<Range*>::const_iterator rangesEnd = m_ranges.end(); 3520 HashSet<Range*>::const_iterator rangesEnd = m_ranges.end();
3521 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != ranges End; ++it) 3521 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != ranges End; ++it)
3522 (*it)->nodeWillBeRemoved(n); 3522 (*it)->nodeWillBeRemoved(n);
3523 } 3523 }
(...skipping 1734 matching lines...) Expand 10 before | Expand all | Expand 10 after
5258 void Document::modifiedStyleSheet(StyleSheet* sheet, RecalcStyleTime when, Style ResolverUpdateMode updateMode) 5258 void Document::modifiedStyleSheet(StyleSheet* sheet, RecalcStyleTime when, Style ResolverUpdateMode updateMode)
5259 { 5259 {
5260 if (!isActive()) 5260 if (!isActive())
5261 return; 5261 return;
5262 5262
5263 styleEngine()->modifiedStyleSheet(sheet); 5263 styleEngine()->modifiedStyleSheet(sheet);
5264 styleResolverChanged(when, updateMode); 5264 styleResolverChanged(when, updateMode);
5265 } 5265 }
5266 5266
5267 } // namespace WebCore 5267 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/NodeIterator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698