Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 487543002: Revert 290359 "Remove AudioBuffersState class." (Closed)

Created:
6 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 290359 "Remove AudioBuffersState class." Broke ChromeOS bots http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/70835/steps/compile/logs/stdio#error1 > Remove AudioBuffersState class. > > The AudioBuffersState object doesn't appear to be necessary anymore. > Most code either completely ignores this information or doesn't actually > care about the difference between pending_bytes and hardware_delay_bytes. > Also usually only one of the 2 fields was actually being used at a time. > This change removes the class and simply uses an int that represent the > total number of delay bytes. > > BUG=125685 > > Review URL: https://codereview.chromium.org/467833002 TBR=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -83 lines) Patch
M trunk/src/components/copresence/mediums/audio/audio_player.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/copresence/mediums/audio/audio_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/copresence/mediums/audio/audio_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/media/audio_sync_reader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/common/media/audio_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/media/audio/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/media/audio/alsa/alsa_output.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/alsa/alsa_output.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/audio/alsa/alsa_output_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M trunk/src/media/audio/android/audio_android_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/audio/android/opensles_output.cc View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/media/audio/audio_buffers_state.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/media/audio/audio_buffers_state.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/media/audio/audio_io.h View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M trunk/src/media/audio/audio_output_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/audio_output_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/audio_output_proxy_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/media/audio/audio_output_resampler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/media/audio/audio_output_resampler.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M trunk/src/media/audio/cras/cras_unified.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/media/audio/fake_audio_consumer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/media/audio/fake_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/mac/audio_auhal_mac.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/media/audio/mock_audio_source_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/pulse/pulse_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/simple_sources.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/simple_sources.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/simple_sources_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/media/audio/sounds/audio_stream_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/media/audio/virtual_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_output_win.cc View 1 chunk +5 lines, -1 line 0 comments Download
M trunk/src/media/audio/win/audio_low_latency_output_win_unittest.cc View 5 chunks +18 lines, -9 lines 0 comments Download
M trunk/src/media/audio/win/audio_output_win_unittest.cc View 7 chunks +27 lines, -17 lines 0 comments Download
M trunk/src/media/audio/win/waveout_output_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/media/cast/test/receiver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/media/cast/test/utility/audio_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 4 months ago (2014-08-18 22:08:16 UTC) #1
acolwell GONE FROM CHROMIUM
6 years, 4 months ago (2014-08-18 22:08:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r290376.

Powered by Google App Engine
This is Rietveld 408576698