Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 467833002: Remove AudioBuffersState class. (Closed)

Created:
6 years, 4 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 4 months ago
Reviewers:
rkc, palmer, DaleCurtis
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, mikhal+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove AudioBuffersState class. The AudioBuffersState object doesn't appear to be necessary anymore. Most code either completely ignores this information or doesn't actually care about the difference between pending_bytes and hardware_delay_bytes. Also usually only one of the 2 fields was actually being used at a time. This change removes the class and simply uses an int that represent the total number of delay bytes. BUG=125685 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290359

Patch Set 1 #

Patch Set 2 : Update BUILD.gn #

Patch Set 3 : Fix build busters #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -182 lines) Patch
M components/copresence/mediums/audio/audio_player.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/mediums/audio/audio_player.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/mediums/audio/audio_player_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/media/audio_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/alsa/alsa_output.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/alsa_output.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/audio/android/opensles_output.cc View 1 chunk +1 line, -1 line 0 comments Download
D media/audio/audio_buffers_state.h View 1 chunk +0 lines, -32 lines 0 comments Download
D media/audio/audio_buffers_state.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M media/audio/audio_io.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/audio/audio_output_resampler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M media/audio/cras/cras_unified.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/audio/fake_audio_consumer_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/audio/fake_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/audio/mock_audio_source_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/pulse/pulse_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/audio/virtual_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +1 line, -5 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 2 5 chunks +9 lines, -18 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 7 chunks +17 lines, -27 lines 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M media/cast/test/receiver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/utility/audio_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
acolwell GONE FROM CHROMIUM
Please take a look. I'm intentionally not changing the parameter units like a comment in ...
6 years, 4 months ago (2014-08-12 20:22:10 UTC) #1
DaleCurtis
Thanks for doing this! Is your end goal http://crbug.com/125685 ?
6 years, 4 months ago (2014-08-12 20:39:35 UTC) #2
DaleCurtis
Also, lgtm once the bots are happy. I suspect there are some PPAPI / NaCl ...
6 years, 4 months ago (2014-08-12 20:39:56 UTC) #3
acolwell GONE FROM CHROMIUM
On 2014/08/12 20:39:35, DaleCurtis wrote: > Thanks for doing this! Is your end goal http://crbug.com/125685 ...
6 years, 4 months ago (2014-08-12 22:11:59 UTC) #4
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 4 months ago (2014-08-13 03:42:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/467833002/40001
6 years, 4 months ago (2014-08-13 03:43:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 09:08:43 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 09:12:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3894)
6 years, 4 months ago (2014-08-13 09:13:00 UTC) #9
acolwell GONE FROM CHROMIUM
rkc : Please OWNERS review components/copresence changes palmer: Please OWNERS review content/common/media/audio_messages.h
6 years, 4 months ago (2014-08-13 16:21:02 UTC) #10
rkc
lgtm for copresence/*
6 years, 4 months ago (2014-08-13 16:57:49 UTC) #11
miu
Yeah, I wanted to tackle this to improve the timing information being provided to the ...
6 years, 4 months ago (2014-08-13 21:17:31 UTC) #12
acolwell GONE FROM CHROMIUM
palmer@: ping for OWNERS review. It is a trivial removal of an unused include so ...
6 years, 4 months ago (2014-08-15 16:32:43 UTC) #13
palmer
Rubberstamp LGTM
6 years, 4 months ago (2014-08-18 17:39:14 UTC) #14
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 4 months ago (2014-08-18 18:02:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/467833002/60001
6 years, 4 months ago (2014-08-18 18:03:23 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-18 19:51:35 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 20:49:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (60001) as 290359

Powered by Google App Engine
This is Rietveld 408576698