Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: trunk/src/media/audio/audio_output_resampler.cc

Issue 487543002: Revert 290359 "Remove AudioBuffersState class." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/media/audio/audio_output_resampler.h ('k') | trunk/src/media/audio/cras/cras_unified.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/media/audio/audio_output_resampler.cc
===================================================================
--- trunk/src/media/audio/audio_output_resampler.cc (revision 290374)
+++ trunk/src/media/audio/audio_output_resampler.cc (working copy)
@@ -30,7 +30,7 @@
// AudioSourceCallback interface.
virtual int OnMoreData(AudioBus* dest,
- int total_bytes_delay) OVERRIDE;
+ AudioBuffersState buffers_state) OVERRIDE;
virtual void OnError(AudioOutputStream* stream) OVERRIDE;
// Sets |source_callback_|. If this is not a new object, then Stop() must be
@@ -54,9 +54,9 @@
// Source callback.
AudioOutputStream::AudioSourceCallback* source_callback_;
- // Last |total_bytes_delay| received via OnMoreData(), used to correct
+ // Last AudioBuffersState object received via OnMoreData(), used to correct
// playback delay by ProvideInput() and passed on to |source_callback_|.
- int current_total_bytes_delay_;
+ AudioBuffersState current_buffers_state_;
const int input_bytes_per_second_;
@@ -327,8 +327,8 @@
}
int OnMoreDataConverter::OnMoreData(AudioBus* dest,
- int total_bytes_delay) {
- current_total_bytes_delay_ = total_bytes_delay;
+ AudioBuffersState buffers_state) {
+ current_buffers_state_ = buffers_state;
audio_converter_.Convert(dest);
// Always return the full number of frames requested, ProvideInput()
@@ -341,12 +341,13 @@
// Adjust playback delay to include |buffer_delay|.
// TODO(dalecurtis): Stop passing bytes around, it doesn't make sense since
// AudioBus is just float data. Use TimeDelta instead.
- int new_total_bytes_delay =
- io_ratio_ * (current_total_bytes_delay_ +
+ AudioBuffersState new_buffers_state;
+ new_buffers_state.pending_bytes =
+ io_ratio_ * (current_buffers_state_.total_bytes() +
buffer_delay.InSecondsF() * input_bytes_per_second_);
// Retrieve data from the original callback.
- const int frames = source_callback_->OnMoreData(dest, new_total_bytes_delay);
+ const int frames = source_callback_->OnMoreData(dest, new_buffers_state);
// Zero any unfilled frames if anything was filled, otherwise we'll just
// return a volume of zero and let AudioConverter drop the output.
« no previous file with comments | « trunk/src/media/audio/audio_output_resampler.h ('k') | trunk/src/media/audio/cras/cras_unified.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698