Refactor HistoryService to not send NOTIFICATION_FAVICON_CHANGED

Refactor HistoryService to not send NOTIFICATION_FAVICON_CHANGED

Use a base::CallbackList<void(HistoryService*, const std::set<GURL>&) to
register and notify objects interested in change to favicon urls. The
callback will be sent at the point the notification would have been called.

Refactor HistoryBackend and HistoryService to change how the notification
is forwarded (remove the notification and introduce explicit methods).

Change how notification are forwared on android from a pair of vector of
notification type and notification detail to a list of callbacks.

BUG=373320
Committed: https://crrev.com/ba90edc1df14a90c43327329a43f64910ce2fc81
Cr-Commit-Position: refs/heads/master@{#293967}

[sdefresne, 2014-08-19 15:23:41]

brettw@chromium.org: Please review changes in //chrome/browser/history,
//chrome/browser/bookmarks & //components/history.

jochen@chromium.org: Please review changes in
//chrome/browser/chrome_notification_types.h, //chrome/browser/favicon &
//chrome/browser/sync.

[brettw, 2014-08-25 19:44:42]

Is this still relevant? It sounds like something I already reviewed, but I might
be getting confused.

[sdefresne, 2014-09-01 07:50:53]

On 2014/08/25 19:44:42, brettw wrote:
> Is this still relevant? It sounds like something I already reviewed, but I
might
> be getting confused.

Yes, this is still relevant. You may be confusing it with
https://codereview.chromium.org/441623002/ from naiem.shaik@ that remove another
notification type. This is the first time I've sent this CL for review :-)

[brettw, 2014-09-02 23:23:10]

lgtm

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
File chrome/browser/history/android/android_provider_backend.cc (right):

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
chrome/browser/history/android/android_provider_backend.cc:118:
scoped_ptr<std::set<GURL>> changed_favicons) {
Put space in >> (still no C++11 in codebase). Same below.

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
File chrome/browser/history/android/android_provider_backend_unittest.cc
(right):

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
chrome/browser/history/android/android_provider_backend_unittest.cc:108:
scoped_ptr<std::set<GURL>> favicon_changed_;
Ditto on >>

[jochen (gone - plz use gerrit), 2014-09-03 08:14:33]

lgtm

[sdefresne, 2014-09-03 09:59:24]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-03 09:59:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/484213002/40001

[sdefresne, 2014-09-03 10:00:01]

Thank you for the review.

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
File chrome/browser/history/android/android_provider_backend.cc (right):

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
chrome/browser/history/android/android_provider_backend.cc:118:
scoped_ptr<std::set<GURL>> changed_favicons) {
On 2014/09/02 23:23:10, brettw wrote:
> Put space in >> (still no C++11 in codebase). Same below.

Done.

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
File chrome/browser/history/android/android_provider_backend_unittest.cc
(right):

https://codereview.chromium.org/484213002/diff/20001/chrome/browser/history/a...
chrome/browser/history/android/android_provider_backend_unittest.cc:108:
scoped_ptr<std::set<GURL>> favicon_changed_;
On 2014/09/02 23:23:10, brettw wrote:
> Ditto on >>

Done.

[commit-bot: I haz the power, 2014-09-03 16:07:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-09-03 16:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 16:15:34]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sdefresne, 2014-09-08 14:41:53]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-08 14:42:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/484213002/80001

[commit-bot: I haz the power, 2014-09-08 16:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 16:45:33]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[sdefresne, 2014-09-08 17:38:13]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-08 17:39:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/484213002/100001

[commit-bot: I haz the power, 2014-09-08 19:47:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 19:47:01]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[sdefresne, 2014-09-09 16:53:44]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-09-09 16:57:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/484213002/120001

[commit-bot: I haz the power, 2014-09-09 18:13:20]

Committed patchset #7 (id:120001) as b195be5c90601c9cb26e5e77ee6a6070916ac2b8

[commit-bot: I haz the power, 2014-09-10 03:54:17]

Patchset 7 (id:??) landed as
https://crrev.com/ba90edc1df14a90c43327329a43f64910ce2fc81
Cr-Commit-Position: refs/heads/master@{#293967}