Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/browser/history/history_backend.h

Issue 484213002: Refactor HistoryService to not send NOTIFICATION_FAVICON_CHANGED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android unit tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // Sets the in-memory history backend. The in-memory backend is created by 113 // Sets the in-memory history backend. The in-memory backend is created by
114 // the main backend. For non-unit tests, this happens on the background 114 // the main backend. For non-unit tests, this happens on the background
115 // thread. It is to be used on the main thread, so this would transfer 115 // thread. It is to be used on the main thread, so this would transfer
116 // it to the history service. Unit tests can override this behavior. 116 // it to the history service. Unit tests can override this behavior.
117 // 117 //
118 // This function is NOT guaranteed to be called. If there is an error, 118 // This function is NOT guaranteed to be called. If there is an error,
119 // there may be no in-memory database. 119 // there may be no in-memory database.
120 virtual void SetInMemoryBackend( 120 virtual void SetInMemoryBackend(
121 scoped_ptr<InMemoryHistoryBackend> backend) = 0; 121 scoped_ptr<InMemoryHistoryBackend> backend) = 0;
122 122
123 // Notify HistoryService that some URLs favicon changed that will forward
124 // the events to the FaviconChangedObservers in the correct thread.
125 virtual void NotifyFaviconChanged(const std::set<GURL>& urls) = 0;
126
123 // Broadcasts the specified notification to the notification service. 127 // Broadcasts the specified notification to the notification service.
124 // This is implemented here because notifications must only be sent from 128 // This is implemented here because notifications must only be sent from
125 // the main thread. This is the only method that doesn't identify the 129 // the main thread. This is the only method that doesn't identify the
126 // caller because notifications must always be sent. 130 // caller because notifications must always be sent.
127 virtual void BroadcastNotifications(int type, 131 virtual void BroadcastNotifications(int type,
128 scoped_ptr<HistoryDetails> details) = 0; 132 scoped_ptr<HistoryDetails> details) = 0;
129 133
130 // Invoked when the backend has finished loading the db. 134 // Invoked when the backend has finished loading the db.
131 virtual void DBLoaded() = 0; 135 virtual void DBLoaded() = 0;
132 136
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
888 892
889 // Listens for the system being under memory pressure. 893 // Listens for the system being under memory pressure.
890 scoped_ptr<base::MemoryPressureListener> memory_pressure_listener_; 894 scoped_ptr<base::MemoryPressureListener> memory_pressure_listener_;
891 895
892 DISALLOW_COPY_AND_ASSIGN(HistoryBackend); 896 DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
893 }; 897 };
894 898
895 } // namespace history 899 } // namespace history
896 900
897 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 901 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/android/android_provider_backend_unittest.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698