Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/history/history_unittest.cc

Issue 484213002: Refactor HistoryService to not send NOTIFICATION_FAVICON_CHANGED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android unit tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // History unit tests come in two flavors: 5 // History unit tests come in two flavors:
6 // 6 //
7 // 1. The more complicated style is that the unit test creates a full history 7 // 1. The more complicated style is that the unit test creates a full history
8 // service. This spawns a background thread for the history backend, and 8 // service. This spawns a background thread for the history backend, and
9 // all communication is asynchronous. This is useful for testing more 9 // all communication is asynchronous. This is useful for testing more
10 // complicated things or end-to-end behavior. 10 // complicated things or end-to-end behavior.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // HistoryBackendDBTest to work. 89 // HistoryBackendDBTest to work.
90 class BackendDelegate : public HistoryBackend::Delegate { 90 class BackendDelegate : public HistoryBackend::Delegate {
91 public: 91 public:
92 explicit BackendDelegate(HistoryBackendDBTest* history_test) 92 explicit BackendDelegate(HistoryBackendDBTest* history_test)
93 : history_test_(history_test) { 93 : history_test_(history_test) {
94 } 94 }
95 95
96 virtual void NotifyProfileError(sql::InitStatus init_status) OVERRIDE {} 96 virtual void NotifyProfileError(sql::InitStatus init_status) OVERRIDE {}
97 virtual void SetInMemoryBackend( 97 virtual void SetInMemoryBackend(
98 scoped_ptr<InMemoryHistoryBackend> backend) OVERRIDE; 98 scoped_ptr<InMemoryHistoryBackend> backend) OVERRIDE;
99 virtual void NotifyFaviconChanged(const std::set<GURL>& url) OVERRIDE {}
99 virtual void BroadcastNotifications( 100 virtual void BroadcastNotifications(
100 int type, 101 int type,
101 scoped_ptr<HistoryDetails> details) OVERRIDE; 102 scoped_ptr<HistoryDetails> details) OVERRIDE;
102 virtual void DBLoaded() OVERRIDE {} 103 virtual void DBLoaded() OVERRIDE {}
103 virtual void NotifyVisitDBObserversOnAddVisit( 104 virtual void NotifyVisitDBObserversOnAddVisit(
104 const BriefVisitInfo& info) OVERRIDE {} 105 const BriefVisitInfo& info) OVERRIDE {}
105 private: 106 private:
106 HistoryBackendDBTest* history_test_; 107 HistoryBackendDBTest* history_test_;
107 }; 108 };
108 109
(...skipping 1756 matching lines...) Expand 10 before | Expand all | Expand 10 after
1865 std::vector<PageUsageData*> results; 1866 std::vector<PageUsageData*> results;
1866 db_->QuerySegmentUsage(segment_time, 10, &results); 1867 db_->QuerySegmentUsage(segment_time, 10, &results);
1867 ASSERT_EQ(1u, results.size()); 1868 ASSERT_EQ(1u, results.size());
1868 EXPECT_EQ(url, results[0]->GetURL()); 1869 EXPECT_EQ(url, results[0]->GetURL());
1869 EXPECT_EQ(segment_id, results[0]->GetID()); 1870 EXPECT_EQ(segment_id, results[0]->GetID());
1870 EXPECT_EQ(title, results[0]->GetTitle()); 1871 EXPECT_EQ(title, results[0]->GetTitle());
1871 STLDeleteElements(&results); 1872 STLDeleteElements(&results);
1872 } 1873 }
1873 1874
1874 } // namespace history 1875 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/history_service_factory.cc ('k') | chrome/browser/sync/sessions/notification_service_sessions_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698