Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2806)

Unified Diff: chrome/browser/history/android/android_provider_backend.h

Issue 484213002: Refactor HistoryService to not send NOTIFICATION_FAVICON_CHANGED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android unit tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/DEPS ('k') | chrome/browser/history/android/android_provider_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/android/android_provider_backend.h
diff --git a/chrome/browser/history/android/android_provider_backend.h b/chrome/browser/history/android/android_provider_backend.h
index 02dff9b707de43b5e5710343c0f4b2862a5285db..62acfe73f536dc95c15479a08c80cb9cfaead891 100644
--- a/chrome/browser/history/android/android_provider_backend.h
+++ b/chrome/browser/history/android/android_provider_backend.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_HISTORY_ANDROID_ANDROID_PROVIDER_BACKEND_H_
#define CHROME_BROWSER_HISTORY_ANDROID_ANDROID_PROVIDER_BACKEND_H_
+#include <list>
#include <set>
#include "base/containers/hash_tables.h"
@@ -146,23 +147,7 @@ class AndroidProviderBackend {
FRIEND_TEST_ALL_PREFIXES(AndroidProviderBackendTest, UpdateTables);
FRIEND_TEST_ALL_PREFIXES(AndroidProviderBackendTest, UpdateSearchTermTable);
- class HistoryNotifications {
- public:
- HistoryNotifications();
- ~HistoryNotifications();
-
- void PushBack(int type, scoped_ptr<HistoryDetails> detail);
- int PopBackType();
- scoped_ptr<HistoryDetails> PopBackDetails();
-
- bool empty() const { return types_.empty(); }
-
- private:
- std::vector<int> types_;
- ScopedVector<HistoryDetails> details_;
-
- DISALLOW_COPY_AND_ASSIGN(HistoryNotifications);
- };
+ typedef std::list<base::Closure> HistoryNotifications;
// The scoped transaction for AndroidProviderBackend.
//
« no previous file with comments | « chrome/browser/history/DEPS ('k') | chrome/browser/history/android/android_provider_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698