Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3216)

Unified Diff: chrome/browser/sync/sessions/notification_service_sessions_router.h

Issue 484213002: Refactor HistoryService to not send NOTIFICATION_FAVICON_CHANGED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix android unit tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/notification_service_sessions_router.h
diff --git a/chrome/browser/sync/sessions/notification_service_sessions_router.h b/chrome/browser/sync/sessions/notification_service_sessions_router.h
index 7ce1c144c67c3c4632c52d599617a6b85eb203f2..a873d24880f2835d2a028cb44ea568e2385c04e0 100644
--- a/chrome/browser/sync/sessions/notification_service_sessions_router.h
+++ b/chrome/browser/sync/sessions/notification_service_sessions_router.h
@@ -5,11 +5,16 @@
#ifndef CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_
#define CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_
+#include <set>
+
+#include "base/callback_list.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/sync/sessions/sessions_sync_manager.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+class GURL;
+class HistoryService;
class Profile;
namespace content {
@@ -47,12 +52,18 @@ class NotificationServiceSessionsRouter
// from WebContents.
void OnNavigationBlocked(content::WebContents* web_contents);
+ // Called when the urls of favicon changed.
+ void OnFaviconChanged(const std::set<GURL>& changed_favicons);
+
LocalSessionEventHandler* handler_;
content::NotificationRegistrar registrar_;
Profile* const profile_;
syncer::SyncableService::StartSyncFlare flare_;
base::WeakPtrFactory<NotificationServiceSessionsRouter> weak_ptr_factory_;
+ scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>
+ favicon_changed_subscription_;
+
DISALLOW_COPY_AND_ASSIGN(NotificationServiceSessionsRouter);
};
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/sync/sessions/notification_service_sessions_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698