Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/330440f5b206972a89221671e4b9027b4ec48773 Cr-Commit-Position: refs/heads/master@{#291796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M content/browser/appcache/appcache_disk_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_group_unittest.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/appcache/appcache_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_storage_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/appcache/mock_appcache_storage_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + michaeln@chromium.org
6 years, 4 months ago (2014-08-25 21:55:31 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-25 21:55:31 UTC) #2
michaeln
lgtm
6 years, 4 months ago (2014-08-25 22:10:35 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-25 22:13:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/478053003/1
6 years, 4 months ago (2014-08-25 22:15:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as ae368de52a518366f2f4eadc953c03dcf0337698
6 years, 4 months ago (2014-08-25 23:59:08 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/330440f5b206972a89221671e4b9027b4ec48773
Cr-Commit-Position: refs/heads/master@{#291796}

Powered by Google App Engine
This is Rietveld 408576698