Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Side by Side Diff: content/browser/appcache/appcache_group_unittest.cc

Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "content/browser/appcache/appcache.h" 8 #include "content/browser/appcache/appcache.h"
9 #include "content/browser/appcache/appcache_group.h" 9 #include "content/browser/appcache/appcache_group.h"
10 #include "content/browser/appcache/appcache_host.h" 10 #include "content/browser/appcache/appcache_host.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 MockAppCacheService service; 104 MockAppCacheService service;
105 scoped_refptr<AppCacheGroup> group( 105 scoped_refptr<AppCacheGroup> group(
106 new AppCacheGroup(service.storage(), GURL("http://foo.com"), 111)); 106 new AppCacheGroup(service.storage(), GURL("http://foo.com"), 111));
107 107
108 base::Time now = base::Time::Now(); 108 base::Time now = base::Time::Now();
109 109
110 scoped_refptr<AppCache> cache1(new AppCache(service.storage(), 111)); 110 scoped_refptr<AppCache> cache1(new AppCache(service.storage(), 111));
111 cache1->set_complete(true); 111 cache1->set_complete(true);
112 cache1->set_update_time(now); 112 cache1->set_update_time(now);
113 group->AddCache(cache1.get()); 113 group->AddCache(cache1.get());
114 EXPECT_EQ(cache1, group->newest_complete_cache()); 114 EXPECT_EQ(cache1.get(), group->newest_complete_cache());
115 115
116 // Adding older cache does not change newest complete cache. 116 // Adding older cache does not change newest complete cache.
117 scoped_refptr<AppCache> cache2(new AppCache(service.storage(), 222)); 117 scoped_refptr<AppCache> cache2(new AppCache(service.storage(), 222));
118 cache2->set_complete(true); 118 cache2->set_complete(true);
119 cache2->set_update_time(now - base::TimeDelta::FromDays(1)); 119 cache2->set_update_time(now - base::TimeDelta::FromDays(1));
120 group->AddCache(cache2.get()); 120 group->AddCache(cache2.get());
121 EXPECT_EQ(cache1, group->newest_complete_cache()); 121 EXPECT_EQ(cache1.get(), group->newest_complete_cache());
122 122
123 // Adding newer cache does change newest complete cache. 123 // Adding newer cache does change newest complete cache.
124 scoped_refptr<AppCache> cache3(new AppCache(service.storage(), 333)); 124 scoped_refptr<AppCache> cache3(new AppCache(service.storage(), 333));
125 cache3->set_complete(true); 125 cache3->set_complete(true);
126 cache3->set_update_time(now + base::TimeDelta::FromDays(1)); 126 cache3->set_update_time(now + base::TimeDelta::FromDays(1));
127 group->AddCache(cache3.get()); 127 group->AddCache(cache3.get());
128 EXPECT_EQ(cache3, group->newest_complete_cache()); 128 EXPECT_EQ(cache3.get(), group->newest_complete_cache());
129 129
130 // Adding cache with same update time uses one with larger ID. 130 // Adding cache with same update time uses one with larger ID.
131 scoped_refptr<AppCache> cache4(new AppCache(service.storage(), 444)); 131 scoped_refptr<AppCache> cache4(new AppCache(service.storage(), 444));
132 cache4->set_complete(true); 132 cache4->set_complete(true);
133 cache4->set_update_time(now + base::TimeDelta::FromDays(1)); // same as 3 133 cache4->set_update_time(now + base::TimeDelta::FromDays(1)); // same as 3
134 group->AddCache(cache4.get()); 134 group->AddCache(cache4.get());
135 EXPECT_EQ(cache4, group->newest_complete_cache()); 135 EXPECT_EQ(cache4.get(), group->newest_complete_cache());
136 136
137 // smaller id 137 // smaller id
138 scoped_refptr<AppCache> cache5(new AppCache(service.storage(), 55)); 138 scoped_refptr<AppCache> cache5(new AppCache(service.storage(), 55));
139 cache5->set_complete(true); 139 cache5->set_complete(true);
140 cache5->set_update_time(now + base::TimeDelta::FromDays(1)); // same as 4 140 cache5->set_update_time(now + base::TimeDelta::FromDays(1)); // same as 4
141 group->AddCache(cache5.get()); 141 group->AddCache(cache5.get());
142 EXPECT_EQ(cache4, group->newest_complete_cache()); // no change 142 EXPECT_EQ(cache4.get(), group->newest_complete_cache()); // no change
143 143
144 // Old caches can always be removed. 144 // Old caches can always be removed.
145 group->RemoveCache(cache1.get()); 145 group->RemoveCache(cache1.get());
146 EXPECT_FALSE(cache1->owning_group()); 146 EXPECT_FALSE(cache1->owning_group());
147 EXPECT_EQ(cache4, group->newest_complete_cache()); // newest unchanged 147 EXPECT_EQ(cache4.get(), group->newest_complete_cache()); // newest unchanged
148 148
149 // Remove rest of caches. 149 // Remove rest of caches.
150 group->RemoveCache(cache2.get()); 150 group->RemoveCache(cache2.get());
151 EXPECT_FALSE(cache2->owning_group()); 151 EXPECT_FALSE(cache2->owning_group());
152 EXPECT_EQ(cache4, group->newest_complete_cache()); // newest unchanged 152 EXPECT_EQ(cache4.get(), group->newest_complete_cache()); // newest unchanged
153 group->RemoveCache(cache3.get()); 153 group->RemoveCache(cache3.get());
154 EXPECT_FALSE(cache3->owning_group()); 154 EXPECT_FALSE(cache3->owning_group());
155 EXPECT_EQ(cache4, group->newest_complete_cache()); // newest unchanged 155 EXPECT_EQ(cache4.get(), group->newest_complete_cache()); // newest unchanged
156 group->RemoveCache(cache5.get()); 156 group->RemoveCache(cache5.get());
157 EXPECT_FALSE(cache5->owning_group()); 157 EXPECT_FALSE(cache5->owning_group());
158 EXPECT_EQ(cache4, group->newest_complete_cache()); // newest unchanged 158 EXPECT_EQ(cache4.get(), group->newest_complete_cache()); // newest unchanged
159 group->RemoveCache(cache4.get()); // newest removed 159 group->RemoveCache(cache4.get()); // newest removed
160 EXPECT_FALSE(cache4->owning_group()); 160 EXPECT_FALSE(cache4->owning_group());
161 EXPECT_FALSE(group->newest_complete_cache()); // no more newest cache 161 EXPECT_FALSE(group->newest_complete_cache()); // no more newest cache
162 162
163 // Can remove newest cache if there are older caches. 163 // Can remove newest cache if there are older caches.
164 group->AddCache(cache1.get()); 164 group->AddCache(cache1.get());
165 EXPECT_EQ(cache1, group->newest_complete_cache()); 165 EXPECT_EQ(cache1.get(), group->newest_complete_cache());
166 group->AddCache(cache4.get()); 166 group->AddCache(cache4.get());
167 EXPECT_EQ(cache4, group->newest_complete_cache()); 167 EXPECT_EQ(cache4.get(), group->newest_complete_cache());
168 group->RemoveCache(cache4.get()); // remove newest 168 group->RemoveCache(cache4.get()); // remove newest
169 EXPECT_FALSE(cache4->owning_group()); 169 EXPECT_FALSE(cache4->owning_group());
170 EXPECT_FALSE(group->newest_complete_cache()); // newest removed 170 EXPECT_FALSE(group->newest_complete_cache()); // newest removed
171 } 171 }
172 172
173 TEST_F(AppCacheGroupTest, CleanupUnusedGroup) { 173 TEST_F(AppCacheGroupTest, CleanupUnusedGroup) {
174 MockAppCacheService service; 174 MockAppCacheService service;
175 TestAppCacheFrontend frontend; 175 TestAppCacheFrontend frontend;
176 AppCacheGroup* group = 176 AppCacheGroup* group =
177 new AppCacheGroup(service.storage(), GURL("http://foo.com"), 111); 177 new AppCacheGroup(service.storage(), GURL("http://foo.com"), 111);
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 EXPECT_TRUE(group->FindObserver(&host, group->observers_)); 293 EXPECT_TRUE(group->FindObserver(&host, group->observers_));
294 294
295 // Delete update to cause it to complete. Verify host is notified. 295 // Delete update to cause it to complete. Verify host is notified.
296 delete group->update_job_; 296 delete group->update_job_;
297 EXPECT_EQ(AppCacheGroup::IDLE, group->update_status_); 297 EXPECT_EQ(AppCacheGroup::IDLE, group->update_status_);
298 EXPECT_TRUE(group->restart_update_task_.IsCancelled()); 298 EXPECT_TRUE(group->restart_update_task_.IsCancelled());
299 EXPECT_TRUE(host.update_completed_); 299 EXPECT_TRUE(host.update_completed_);
300 } 300 }
301 301
302 } // namespace content 302 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/appcache/appcache_disk_cache_unittest.cc ('k') | content/browser/appcache/appcache_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698