content/browser/appcache/appcache_update_job_unittest.cc - Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_update_job_unittest.cc

Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_storage_impl_unittest.cc ('k') | content/browser/appcache/mock_appcache_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_update_job_unittest.cc

diff --git a/content/browser/appcache/appcache_update_job_unittest.cc b/content/browser/appcache/appcache_update_job_unittest.cc

index 6eb4e02506e6e4f5ccafdde3af0ff7803da68bbe..c7a2e704ae2ba7856c1987233984e94f4ba78603 100644

--- a/content/browser/appcache/appcache_update_job_unittest.cc

+++ b/content/browser/appcache/appcache_update_job_unittest.cc

@@ -3018,7 +3018,7 @@ class AppCacheUpdateJobTest : public testing::Test,

}

virtual void OnUpdateComplete(AppCacheGroup* group) OVERRIDE {

- ASSERT_EQ(group_, group);

+ ASSERT_EQ(group_.get(), group);

protect_newest_cache_ = group->newest_complete_cache();

UpdateFinished();

}

@@ -3192,7 +3192,7 @@ class AppCacheUpdateJobTest : public testing::Test,

if (tested_manifest_) {

AppCache* cache = group_->newest_complete_cache();

ASSERT_TRUE(cache != NULL);

- EXPECT_EQ(group_, cache->owning_group());

+ EXPECT_EQ(group_.get(), cache->owning_group());

EXPECT_TRUE(cache->is_complete());

switch (tested_manifest_) {