content/browser/appcache/appcache_storage_impl.cc - Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_storage_impl.cc

Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_request_handler_unittest.cc ('k') | content/browser/appcache/appcache_storage_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_storage_impl.cc

diff --git a/content/browser/appcache/appcache_storage_impl.cc b/content/browser/appcache/appcache_storage_impl.cc

index 59cc5817ec918b6c1321e2d3f2fc5e04cb7df067..6e1388be2f53e69cd983329be43947019d776f05 100644

--- a/content/browser/appcache/appcache_storage_impl.cc

+++ b/content/browser/appcache/appcache_storage_impl.cc

@@ -82,7 +82,7 @@ void ClearSessionOnlyOrigins(

return;

bool has_session_only_appcaches =

- special_storage_policy &&

+ special_storage_policy.get() &&

special_storage_policy->HasSessionOnlyOrigins();

// Clearning only session-only databases, and there are none.

@@ -101,7 +101,7 @@ void ClearSessionOnlyOrigins(

}

std::set<GURL>::const_iterator origin;

- DCHECK(special_storage_policy);

+ DCHECK(special_storage_policy.get());

for (origin = origins.begin(); origin != origins.end(); ++origin) {

if (!special_storage_policy->IsStorageSessionOnly(*origin))

continue;

@@ -1351,7 +1351,7 @@ void AppCacheStorageImpl::Initialize(

const base::FilePath& cache_directory,

const scoped_refptr<base::SingleThreadTaskRunner>& db_thread,

const scoped_refptr<base::SingleThreadTaskRunner>& cache_thread) {

- DCHECK(db_thread);

+ DCHECK(db_thread.get());

cache_directory_ = cache_directory;

is_incognito_ = cache_directory_.empty();