content/browser/appcache/appcache_host.cc - Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_host.cc

Issue 478053003: Remove implicit conversions from scoped_refptr to T* in content/browser/appcache/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_group_unittest.cc ('k') | content/browser/appcache/appcache_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_host.cc

diff --git a/content/browser/appcache/appcache_host.cc b/content/browser/appcache/appcache_host.cc

index 2e3c95a26e8b52a2a4da3e54253447a039fd0ff8..9cfcfaca364f7f9c7192a8d1e6c71a1b21589f1f 100644

--- a/content/browser/appcache/appcache_host.cc

+++ b/content/browser/appcache/appcache_host.cc

@@ -442,7 +442,7 @@ void AppCacheHost::ObserveGroupBeingUpdated(AppCacheGroup* group) {

}

void AppCacheHost::OnUpdateComplete(AppCacheGroup* group) {

- DCHECK_EQ(group, group_being_updated_);

+ DCHECK_EQ(group, group_being_updated_.get());

group->RemoveUpdateObserver(this);

// Add a reference to the newest complete cache.

@@ -499,7 +499,7 @@ void AppCacheHost::PrepareForTransfer() {

// This can only happen prior to the document having been loaded.

DCHECK(!associated_cache());

DCHECK(!is_selection_pending());

- DCHECK(!group_being_updated_);

+ DCHECK(!group_being_updated_.get());

host_id_ = kAppCacheNoHostId;

frontend_ = NULL;

}