Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 477133004: Printe Preview: add 'More/less options' button and make non-essential sections collapsible (Closed)

Created:
6 years, 4 months ago by Aleksey Shlyapnikov
Modified:
6 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Changes according to the new mocks and redlines (see the bug description): - make Print button blue and move it in front of Cancel - change 'Backround images and colors' to 'Backround graphics' - remove lines between options and reduce spacing - add 'More/less options' button and make non-essential sections collapsible BUG=397741 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291511

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merging with head. #

Patch Set 3 : Print Preview UI tests adjusted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -201 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_header.css View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_header.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.css View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_animations.js View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/advanced_options_settings.js View 5 chunks +24 lines, -20 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/color_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/color_settings.js View 4 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/copies_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/copies_settings.js View 4 chunks +46 lines, -43 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/destination_settings.js View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/layout_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/layout_settings.js View 4 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/margin_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/margin_settings.js View 4 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.js View 3 chunks +18 lines, -13 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/more_settings.css View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/more_settings.html View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/more_settings.js View 1 chunk +99 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.js View 10 chunks +46 lines, -29 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.js View 7 chunks +18 lines, -12 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/settings_section.js View 1 chunk +118 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 2 9 chunks +110 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Aleksey Shlyapnikov
6 years, 4 months ago (2014-08-15 18:53:59 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/477133004/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/477133004/diff/1/chrome/app/generated_resources.grd#newcode8297 chrome/app/generated_resources.grd:8297: + More options Chrome settings uses "Show advanced ...
6 years, 4 months ago (2014-08-19 18:03:18 UTC) #2
Aleksey Shlyapnikov
https://codereview.chromium.org/477133004/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/477133004/diff/1/chrome/app/generated_resources.grd#newcode8297 chrome/app/generated_resources.grd:8297: + More options On 2014/08/19 18:03:18, Vitaly Buka wrote: ...
6 years, 4 months ago (2014-08-22 01:09:39 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-22 19:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/477133004/40001
6 years, 4 months ago (2014-08-22 19:53:31 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 21:40:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 291511

Powered by Google App Engine
This is Rietveld 408576698