Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 477133004: Printe Preview: add 'More/less options' button and make non-essential sections collapsible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Print Preview UI tests adjusted. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index 5d43e211e03b06547efc591f6b8772f2f88e4497..7e25e2290cad3e8ec4a1a9a74ac6017ad66e5ef1 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -177,6 +177,23 @@ cr.define('print_preview', function() {
this.addChild(this.advancedSettings_);
/**
+ * Component representing more/less settings button.
+ * @type {!print_preview.MoreSettings}
+ * @private
+ */
+ this.moreSettings_ = new print_preview.MoreSettings([
+ this.destinationSettings_,
+ this.pageSettings_,
+ this.copiesSettings_,
+ this.mediaSizeSettings_,
+ this.layoutSettings_,
+ this.marginSettings_,
+ this.colorSettings_,
+ this.otherOptionsSettings_,
+ this.advancedOptionsSettings_]);
+ this.addChild(this.moreSettings_);
+
+ /**
* Area of the UI that holds the print preview.
* @type {!print_preview.PreviewArea}
* @private
@@ -427,6 +444,7 @@ cr.define('print_preview', function() {
this.otherOptionsSettings_.decorate($('other-options-settings'));
this.advancedOptionsSettings_.decorate($('advanced-options-settings'));
this.advancedSettings_.decorate($('advanced-settings'));
+ this.moreSettings_.decorate($('more-settings'));
this.previewArea_.decorate($('preview-area'));
setIsVisible($('open-pdf-in-preview-link'), cr.isMac);
@@ -1190,6 +1208,7 @@ cr.define('print_preview', function() {
<include src="print_header.js"/>
<include src="metrics.js"/>
+<include src="settings/settings_section.js"/>
<include src="settings/page_settings.js"/>
<include src="settings/copies_settings.js"/>
<include src="settings/media_size_settings.js"/>
@@ -1201,6 +1220,7 @@ cr.define('print_preview', function() {
<include src="settings/advanced_options_settings.js"/>
<include src="settings/advanced_settings/advanced_settings.js"/>
<include src="settings/advanced_settings/advanced_settings_item.js"/>
+<include src="settings/more_settings.js"/>
<include src="previewarea/margin_control.js"/>
<include src="previewarea/margin_control_container.js"/>

Powered by Google App Engine
This is Rietveld 408576698