Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4662)

Unified Diff: chrome/browser/resources/print_preview/settings/margin_settings.js

Issue 477133004: Printe Preview: add 'More/less options' button and make non-essential sections collapsible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Print Preview UI tests adjusted. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/margin_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/margin_settings.js b/chrome/browser/resources/print_preview/settings/margin_settings.js
index a7c4400aef30f2b0e9da16eda2cf2db3ee0c3761..2357ea8851c160f0071765551827ad6f840aaf5d 100644
--- a/chrome/browser/resources/print_preview/settings/margin_settings.js
+++ b/chrome/browser/resources/print_preview/settings/margin_settings.js
@@ -11,10 +11,10 @@ cr.define('print_preview', function() {
* @param {!print_preview.ticket_items.MarginsType} marginsTypeTicketItem Used
* to read and write the margins type ticket item.
* @constructor
- * @extends {print_preview.Component}
+ * @extends {print_preview.SettingsSection}
*/
function MarginSettings(marginsTypeTicketItem) {
- print_preview.Component.call(this);
+ print_preview.SettingsSection.call(this);
/**
* Used to read and write the margins type ticket item.
@@ -34,17 +34,26 @@ cr.define('print_preview', function() {
};
MarginSettings.prototype = {
- __proto__: print_preview.Component.prototype,
+ __proto__: print_preview.SettingsSection.prototype,
- /** @param {boolean} isEnabled Whether this component is enabled. */
+ /** @override */
+ isAvailable: function() {
+ return this.marginsTypeTicketItem_.isCapabilityAvailable();
+ },
+
+ /** @override */
+ hasCollapsibleContent: function() {
+ return this.isAvailable();
+ },
+
+ /** @override */
set isEnabled(isEnabled) {
this.select_.disabled = !isEnabled;
},
/** @override */
enterDocument: function() {
- print_preview.Component.prototype.enterDocument.call(this);
- fadeOutOption(this.getElement(), true);
+ print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
this.select_, 'change', this.onSelectChange_.bind(this));
this.tracker.add(
@@ -81,7 +90,7 @@ cr.define('print_preview', function() {
* @private
*/
onMarginsTypeTicketItemChange_: function() {
- if (this.marginsTypeTicketItem_.isCapabilityAvailable()) {
+ if (this.isAvailable()) {
var select = this.select_;
var marginsType = this.marginsTypeTicketItem_.getValue();
var selectedMarginsType =
@@ -91,10 +100,8 @@ cr.define('print_preview', function() {
select.options[selectedMarginsType].selected = false;
select.options[marginsType].selected = true;
}
- fadeInOption(this.getElement());
- } else {
- fadeOutOption(this.getElement());
}
+ this.updateUiStateInternal();
}
};

Powered by Google App Engine
This is Rietveld 408576698