Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: chrome/browser/resources/print_preview/settings/destination_settings.js

Issue 477133004: Printe Preview: add 'More/less options' button and make non-essential sections collapsible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Print Preview UI tests adjusted. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/destination_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/destination_settings.js b/chrome/browser/resources/print_preview/settings/destination_settings.js
index bf0f4457f23617155bfd918cae3c0ea82eeb2ca5..d2a60d5be1ed2a0eabf27329676b58e3131c69b9 100644
--- a/chrome/browser/resources/print_preview/settings/destination_settings.js
+++ b/chrome/browser/resources/print_preview/settings/destination_settings.js
@@ -14,10 +14,10 @@ cr.define('print_preview', function() {
* @param {!print_preview.DestinationStore} destinationStore Used to determine
* the selected destination.
* @constructor
- * @extends {print_preview.Component}
+ * @extends {print_preview.SettingsSection}
*/
function DestinationSettings(destinationStore) {
- print_preview.Component.call(this);
+ print_preview.SettingsSection.call(this);
/**
* Used to determine the selected destination.
@@ -64,9 +64,19 @@ cr.define('print_preview', function() {
};
DestinationSettings.prototype = {
- __proto__: print_preview.Component.prototype,
+ __proto__: print_preview.SettingsSection.prototype,
- /** @param {boolean} Whether the component is enabled. */
+ /** @override */
+ isAvailable: function() {
+ return true;
+ },
+
+ /** @override */
+ hasCollapsibleContent: function() {
+ return false;
+ },
+
+ /** @override */
set isEnabled(isEnabled) {
var changeButton = this.getElement().getElementsByClassName(
DestinationSettings.Classes_.CHANGE_BUTTON)[0];
@@ -75,7 +85,7 @@ cr.define('print_preview', function() {
/** @override */
enterDocument: function() {
- print_preview.Component.prototype.enterDocument.call(this);
+ print_preview.SettingsSection.prototype.enterDocument.call(this);
var changeButton = this.getElement().getElementsByClassName(
DestinationSettings.Classes_.CHANGE_BUTTON)[0];
this.tracker.add(

Powered by Google App Engine
This is Rietveld 408576698