Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: chrome/browser/resources/print_preview/settings/page_settings.js

Issue 477133004: Printe Preview: add 'More/less options' button and make non-essential sections collapsible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Print Preview UI tests adjusted. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/page_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/page_settings.js b/chrome/browser/resources/print_preview/settings/page_settings.js
index f9645444758468429c628bd85b49614e318745e3..9f335170e1a6cd72474392fc3cae637ef691168f 100644
--- a/chrome/browser/resources/print_preview/settings/page_settings.js
+++ b/chrome/browser/resources/print_preview/settings/page_settings.js
@@ -11,10 +11,10 @@ cr.define('print_preview', function() {
* @param {!print_preview.ticket_items.PageRange} pageRangeTicketItem Used to
* read and write page range settings.
* @constructor
- * @extends {print_preview.Component}
+ * @extends {print_preview.SettingsSection}
*/
function PageSettings(pageRangeTicketItem) {
- print_preview.Component.call(this);
+ print_preview.SettingsSection.call(this);
/**
* Used to read and write page range settings.
@@ -79,8 +79,19 @@ cr.define('print_preview', function() {
PageSettings.CUSTOM_INPUT_DELAY_ = 500;
PageSettings.prototype = {
- __proto__: print_preview.Component.prototype,
+ __proto__: print_preview.SettingsSection.prototype,
+ /** @override */
+ isAvailable: function() {
+ return this.pageRangeTicketItem_.isCapabilityAvailable();
+ },
+
+ /** @override */
+ hasCollapsibleContent: function() {
+ return false;
+ },
+
+ /** @override */
set isEnabled(isEnabled) {
this.customInput_.disabled = !isEnabled;
this.allRadio_.disabled = !isEnabled;
@@ -89,8 +100,7 @@ cr.define('print_preview', function() {
/** @override */
enterDocument: function() {
- print_preview.Component.prototype.enterDocument.call(this);
- fadeOutOption(this.getElement(), true);
+ print_preview.SettingsSection.prototype.enterDocument.call(this);
this.tracker.add(
this.allRadio_, 'click', this.onAllRadioClick_.bind(this));
this.tracker.add(
@@ -111,7 +121,7 @@ cr.define('print_preview', function() {
/** @override */
exitDocument: function() {
- print_preview.Component.prototype.exitDocument.call(this);
+ print_preview.SettingsSection.prototype.exitDocument.call(this);
this.customInput_ = null;
this.customRadio_ = null;
this.allRadio_ = null;
@@ -140,12 +150,10 @@ cr.define('print_preview', function() {
setInvalidStateVisible_: function(isVisible) {
if (isVisible) {
this.customInput_.classList.add('invalid');
- this.customHintEl_.setAttribute('aria-hidden', 'false');
fadeInElement(this.customHintEl_);
} else {
this.customInput_.classList.remove('invalid');
fadeOutElement(this.customHintEl_);
- this.customHintEl_.setAttribute('aria-hidden', 'true');
}
},
@@ -235,7 +243,7 @@ cr.define('print_preview', function() {
* @private
*/
onPageRangeTicketItemChange_: function() {
- if (this.pageRangeTicketItem_.isCapabilityAvailable()) {
+ if (this.isAvailable()) {
var pageRangeStr = this.pageRangeTicketItem_.getValue();
if (pageRangeStr || this.customRadio_.checked) {
if (!document.hasFocus() ||
@@ -248,10 +256,8 @@ cr.define('print_preview', function() {
this.allRadio_.checked = true;
this.setInvalidStateVisible_(false);
}
- fadeInOption(this.getElement());
- } else {
- fadeOutOption(this.getElement());
}
+ this.updateUiStateInternal();
}
};

Powered by Google App Engine
This is Rietveld 408576698