Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 474483002: Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..." (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..." > Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace > > Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is > generally a NOP but will allow me to delete the other 4 variants in a followup > (wanted to do that separately since that will require more review, since > callsites will be changed in nontrivial ways). > > In some cases, LowerCaseEqualsASCII is called with a WebString, which no > longer is implicitly converted. I added base::string16(...) around such > calls to force the right conversion. It happened in these files: > window_container_type.cc > savable_resources.cc > render_view_impl.cc > blink_ax_tree_source.cc > password_form_conversion_utils.cc > translate_helper.cc > chrome_render_view_observer.cc > dom_serializer_browsertest.cc > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/448143008 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -489 lines) Patch
M trunk/src/base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/base/files/file_path.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/base/i18n/rtl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/base/strings/string_util.h View 3 chunks +16 lines, -20 lines 0 comments Download
M trunk/src/base/strings/string_util.cc View 2 chunks +18 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/auto_launch_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/autocomplete/search_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/download/download_extensions.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/history/visitsegment_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/io_thread.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/local_discovery/device_description.cc View 2 chunks +11 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/memory_details.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/net/firefox_proxy_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/malware_details_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ssl/ssl_browser_tests.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/themes/theme_properties.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/search/common/webservice_search_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/login/login_prompt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/setup/install_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/installer/util/l10n_string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/chrome_render_view_observer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/translate/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/web_apps.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/element_util.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M trunk/src/chrome/utility/importer/bookmark_html_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/utility/importer/ie_importer_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/components/autofill/content/browser/wallet/form_field_error.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M trunk/src/components/autofill/content/browser/wallet/wallet_client.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M trunk/src/components/autofill/content/browser/wallet/wallet_signin_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill/content/renderer/password_form_conversion_utils.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/components/autofill/core/browser/address.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill/core/browser/autofill_country.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/components/autofill/core/browser/contact_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill/core/browser/credit_card_field.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/components/autofill/core/browser/personal_data_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/components/autofill/core/browser/state_names.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/components/dom_distiller/core/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/google/core/browser/google_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/components/metrics/serialization/serialization_utils.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/src/components/omnibox/autocomplete_input.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/policy/core/common/policy_loader_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/components/search_engines/template_url_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/translate/core/language_detection/language_detection_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/url_fixer/url_fixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/accessibility/browser_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/accessibility/browser_accessibility_state_impl_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/download/download_stats.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/loader/buffered_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/transition_request_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/child/appcache/web_application_cache_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/multipart_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/site_isolation_policy.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/child/webcrypto/shared_crypto_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/content/common/android/address_parser.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M trunk/src/content/common/android/address_parser_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/common/window_container_type.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M trunk/src/content/renderer/accessibility/blink_ax_tree_source.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/android/phone_number_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/dom_serializer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/fetchers/resource_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/media/media_stream_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/savable_resources.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/test/net/url_request_abort_on_end_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/net/url_request_slow_download_job.cc View 4 chunks +11 lines, -14 lines 0 comments Download
M trunk/src/content/test/plugin/plugin_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/extensions/common/csp_validator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/extensions/renderer/runtime_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/gpu/config/gpu_test_expectations_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/base/audio_video_metadata_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/mojo/services/html_viewer/blink_url_request_type_converters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/mojo/services/launcher/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/base/host_mapping_rules.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/base/mime_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/net/filter/filter.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/net/http/http_auth.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/http/http_auth_gssapi_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/http_auth_handler_basic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/http_auth_handler_digest.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M trunk/src/net/http/http_auth_handler_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/http/http_auth_handler_ntlm.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/http/http_auth_handler_ntlm_portable.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/http/http_auth_sspi_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/http_cache_transaction.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/http/http_content_disposition.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M trunk/src/net/http/http_log_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/net/http/http_response_headers.cc View 7 chunks +12 lines, -14 lines 0 comments Download
M trunk/src/net/http/http_security_headers.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/net/http/http_util.cc View 9 chunks +14 lines, -16 lines 0 comments Download
M trunk/src/net/http/http_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/net_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/proxy/proxy_bypass_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/proxy/proxy_server.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M trunk/src/net/url_request/url_request_file_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/url_request/url_request_job_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/websockets/websocket_handshake_handler.cc View 5 chunks +23 lines, -24 lines 0 comments Download
M trunk/src/pdf/document_loader.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/ui/base/l10n/l10n_util.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M trunk/src/ui/base/l10n/l10n_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/base/l10n/l10n_util_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/webkit/common/fileapi/file_system_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 4 months ago (2014-08-13 16:48:32 UTC) #1
brettw
6 years, 4 months ago (2014-08-13 16:48:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r289320.

Powered by Google App Engine
This is Rietveld 408576698