Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/test/chromedriver/element_util.cc

Issue 474483002: Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/renderer/web_apps.cc ('k') | trunk/src/chrome/utility/importer/bookmark_html_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/test/chromedriver/element_util.cc
===================================================================
--- trunk/src/chrome/test/chromedriver/element_util.cc (revision 289319)
+++ trunk/src/chrome/test/chromedriver/element_util.cc (working copy)
@@ -338,12 +338,10 @@
if (status.IsError())
return status;
std::string actual_value;
- if (result->GetAsString(&actual_value)) {
- *is_equal =
- base::LowerCaseEqualsASCII(actual_value, attribute_value.c_str());
- } else {
+ if (result->GetAsString(&actual_value))
+ *is_equal = LowerCaseEqualsASCII(actual_value, attribute_value.c_str());
+ else
*is_equal = false;
- }
return status;
}
« no previous file with comments | « trunk/src/chrome/renderer/web_apps.cc ('k') | trunk/src/chrome/utility/importer/bookmark_html_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698