Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: trunk/src/chrome/browser/autocomplete/search_provider.cc

Issue 474483002: Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/autocomplete/search_provider.cc
===================================================================
--- trunk/src/chrome/browser/autocomplete/search_provider.cc (revision 289319)
+++ trunk/src/chrome/browser/autocomplete/search_provider.cc (working copy)
@@ -588,9 +588,9 @@
// and happens to currently be invalid -- in which case we again want to run
// our checks below. Other QUERY cases are less likely to be URLs and thus we
// assume we're OK.
- if (!base::LowerCaseEqualsASCII(input_.scheme(), url::kHttpScheme) &&
- !base::LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
- !base::LowerCaseEqualsASCII(input_.scheme(), url::kFtpScheme))
+ if (!LowerCaseEqualsASCII(input_.scheme(), url::kHttpScheme) &&
+ !LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
+ !LowerCaseEqualsASCII(input_.scheme(), url::kFtpScheme))
return (input_.type() == metrics::OmniboxInputType::QUERY);
// Don't send URLs with usernames, queries or refs. Some of these are
@@ -612,7 +612,7 @@
// Don't send anything for https except the hostname. Hostnames are OK
// because they are visible when the TCP connection is established, but the
// specific path may reveal private information.
- if (base::LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
+ if (LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
parts.path.is_nonempty())
return false;
« no previous file with comments | « trunk/src/chrome/browser/autocomplete/history_url_provider.cc ('k') | trunk/src/chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698