Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: trunk/src/chrome/browser/local_discovery/device_description.cc

Issue 474483002: Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/io_thread.cc ('k') | trunk/src/chrome/browser/memory_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/local_discovery/device_description.cc
===================================================================
--- trunk/src/chrome/browser/local_discovery/device_description.cc (revision 289319)
+++ trunk/src/chrome/browser/local_discovery/device_description.cc (working copy)
@@ -17,15 +17,13 @@
DeviceDescription::ConnectionState
ConnectionStateFromString(const std::string& str) {
- if (base::LowerCaseEqualsASCII(str, kPrivetConnectionStatusOnline)) {
+ if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusOnline)) {
return DeviceDescription::ONLINE;
- } else if (base::LowerCaseEqualsASCII(str, kPrivetConnectionStatusOffline)) {
+ } else if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusOffline)) {
return DeviceDescription::OFFLINE;
- } else if (base::LowerCaseEqualsASCII(str,
- kPrivetConnectionStatusConnecting)) {
+ } else if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusConnecting)) {
return DeviceDescription::CONNECTING;
- } else if (base::LowerCaseEqualsASCII(str,
- kPrivetConnectionStatusNotConfigured)) {
+ } else if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusNotConfigured)) {
return DeviceDescription::NOT_CONFIGURED;
}
@@ -59,20 +57,20 @@
std::string key = i->substr(0, equals_pos);
std::string value = i->substr(equals_pos + 1);
- if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyVersion)) {
+ if (LowerCaseEqualsASCII(key, kPrivetTxtKeyVersion)) {
if (!base::StringToInt(value, &version))
continue; // Unknown version.
- } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyName)) {
+ } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyName)) {
name = value;
- } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyDescription)) {
+ } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyDescription)) {
description = value;
- } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyURL)) {
+ } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyURL)) {
url = value;
- } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyType)) {
+ } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyType)) {
type = value;
- } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyID)) {
+ } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyID)) {
id = value;
- } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyConnectionState)) {
+ } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyConnectionState)) {
connection_state = ConnectionStateFromString(value);
}
}
« no previous file with comments | « trunk/src/chrome/browser/io_thread.cc ('k') | trunk/src/chrome/browser/memory_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698