Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 464353002: Cleanup blink:: prefix usage in Source/core/modules/[battery/*.cpp to indexeddb/*.cpp] (Closed)

Created:
6 years, 4 months ago by Sunil Ratnu
Modified:
6 years, 4 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews, Inactive, cmumford, dgrogan, eric.carlson_apple.com, feature-media-reviews_chromium.org, jsbell+idb_chromium.org, kinuko+fileapi, mvanouwerkerk+watch_chromium.org, nhiroki, philipj_slow, timvolodine, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup blink:: prefix usage in Source/core/modules/[battery/*.cpp to indexeddb/*.cpp] Cleanup blink:: prefix usage in Source/core/modules/[battery/*.cpp to indexeddb/*.cpp] - Merge multiple |namespace blink {}| blocks - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180272

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -171 lines) Patch
M Source/modules/battery/BatteryDispatcher.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/device_light/DeviceLightDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationDispatcher.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 11 chunks +21 lines, -21 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 12 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeysController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/SimpleContentDecryptionModuleResult.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/FileWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriterBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriterSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/LocalFileSystem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/gamepad/Gamepad.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/GamepadDispatcher.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/gamepad/GamepadList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/gamepad/WebKitGamepad.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepadList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBAny.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 5 chunks +15 lines, -15 lines 0 comments Download
M Source/modules/indexeddb/IDBCursorWithValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 5 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEvent.cpp View 1 3 chunks +6 lines, -7 lines 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Sunil Ratnu
Please review this. Thanks!
6 years, 4 months ago (2014-08-13 15:31:33 UTC) #1
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 4 months ago (2014-08-13 16:32:41 UTC) #2
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-13 16:32:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/464353002/1
6 years, 4 months ago (2014-08-13 16:33:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-13 19:38:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 20:49:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/39580)
6 years, 4 months ago (2014-08-13 20:49:06 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 00:36:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/464353002/1
6 years, 4 months ago (2014-08-14 00:37:35 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 00:38:07 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/modules/indexeddb/IDBCursor.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-14 00:38:08 UTC) #11
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-14 06:31:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/464353002/20001
6 years, 4 months ago (2014-08-14 06:32:33 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-14 08:24:31 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 13:29:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20623)
6 years, 4 months ago (2014-08-14 13:29:51 UTC) #16
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 4 months ago (2014-08-14 15:28:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/464353002/20001
6 years, 4 months ago (2014-08-14 15:32:32 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:34:09 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180272

Powered by Google App Engine
This is Rietveld 408576698