Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 464213005: Allow undefined data param to <appview>.connect (Closed)

Created:
6 years, 4 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow undefined data param to <appview>.connect BUG=239656 TBR=asargent@chromium.org for app_view_browsertest.cc, app_view.js. I'm going to add myself to OWNERs in next patch. Committed: https://crrev.com/e33d7ceba082adcb83e22a3e5f0c4ce45a022903 Cr-Commit-Position: refs/heads/master@{#291697}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/apps/app_view_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/app_view.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/platform_apps/app_view/shim/main.js View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
6 years, 4 months ago (2014-08-14 17:56:25 UTC) #1
Xi Han
lgtm with nit. https://codereview.chromium.org/464213005/diff/1/chrome/test/data/extensions/platform_apps/app_view/shim/main.js File chrome/test/data/extensions/platform_apps/app_view/shim/main.js (right): https://codereview.chromium.org/464213005/diff/1/chrome/test/data/extensions/platform_apps/app_view/shim/main.js#newcode71 chrome/test/data/extensions/platform_apps/app_view/shim/main.js:71: function testAppViewBasic(appToEmbed) { Maybe we can ...
6 years, 4 months ago (2014-08-14 18:30:17 UTC) #2
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 4 months ago (2014-08-25 14:49:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/464213005/20001
6 years, 4 months ago (2014-08-25 14:50:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-25 16:11:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as 93003594bcdf4394342654d6fab521b63ccf7778
6 years, 4 months ago (2014-08-25 16:47:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e33d7ceba082adcb83e22a3e5f0c4ce45a022903
Cr-Commit-Position: refs/heads/master@{#291697}

Powered by Google App Engine
This is Rietveld 408576698