Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/apps/app_view_browsertest.cc

Issue 464213005: Allow undefined data param to <appview>.connect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/app_view.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "chrome/browser/apps/app_browsertest_util.h" 6 #include "chrome/browser/apps/app_browsertest_util.h"
7 #include "chrome/browser/extensions/extension_test_message_listener.h" 7 #include "chrome/browser/extensions/extension_test_message_listener.h"
8 #include "chrome/test/base/ui_test_utils.h" 8 #include "chrome/test/base/ui_test_utils.h"
9 #include "content/public/browser/notification_service.h" 9 #include "content/public/browser/notification_service.h"
10 #include "content/public/browser/render_process_host.h" 10 #include "content/public/browser/render_process_host.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 private: 133 private:
134 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { 134 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
135 command_line->AppendSwitch(extensions::switches::kEnableAppView); 135 command_line->AppendSwitch(extensions::switches::kEnableAppView);
136 extensions::PlatformAppBrowserTest::SetUpCommandLine(command_line); 136 extensions::PlatformAppBrowserTest::SetUpCommandLine(command_line);
137 } 137 }
138 138
139 TestGuestViewManagerFactory factory_; 139 TestGuestViewManagerFactory factory_;
140 }; 140 };
141 141
142 // Tests that <appview> is able to navigate to another installed app. 142 // Tests that <appview> is able to navigate to another installed app.
143 IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewBasic) { 143 IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewWithUndefinedDataShouldSucceed) {
144 const extensions::Extension* skeleton_app = 144 const extensions::Extension* skeleton_app =
145 InstallPlatformApp("app_view/shim/skeleton"); 145 InstallPlatformApp("app_view/shim/skeleton");
146 TestHelper("testAppViewBasic", 146 TestHelper("testAppViewWithUndefinedDataShouldSucceed",
147 "app_view/shim", 147 "app_view/shim",
148 skeleton_app->id(), 148 skeleton_app->id(),
149 NO_TEST_SERVER); 149 NO_TEST_SERVER);
150 } 150 }
151 151
152 // Tests that <appview> correctly processes parameters passed on connect. 152 // Tests that <appview> correctly processes parameters passed on connect.
153 IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewRefusedDataShouldFail) { 153 IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewRefusedDataShouldFail) {
154 const extensions::Extension* skeleton_app = 154 const extensions::Extension* skeleton_app =
155 InstallPlatformApp("app_view/shim/skeleton"); 155 InstallPlatformApp("app_view/shim/skeleton");
156 TestHelper("testAppViewRefusedDataShouldFail", 156 TestHelper("testAppViewRefusedDataShouldFail",
157 "app_view/shim", 157 "app_view/shim",
158 skeleton_app->id(), 158 skeleton_app->id(),
159 NO_TEST_SERVER); 159 NO_TEST_SERVER);
160 } 160 }
161 161
162 // Tests that <appview> correctly processes parameters passed on connect. 162 // Tests that <appview> correctly processes parameters passed on connect.
163 IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewGoodDataShouldSucceed) { 163 IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewGoodDataShouldSucceed) {
164 const extensions::Extension* skeleton_app = 164 const extensions::Extension* skeleton_app =
165 InstallPlatformApp("app_view/shim/skeleton"); 165 InstallPlatformApp("app_view/shim/skeleton");
166 TestHelper("testAppViewGoodDataShouldSucceed", 166 TestHelper("testAppViewGoodDataShouldSucceed",
167 "app_view/shim", 167 "app_view/shim",
168 skeleton_app->id(), 168 skeleton_app->id(),
169 NO_TEST_SERVER); 169 NO_TEST_SERVER);
170 } 170 }
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/app_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698