Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1572)

Unified Diff: chrome/browser/apps/app_view_browsertest.cc

Issue 464213005: Allow undefined data param to <appview>.connect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/app_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_view_browsertest.cc
diff --git a/chrome/browser/apps/app_view_browsertest.cc b/chrome/browser/apps/app_view_browsertest.cc
index c394b281cb27bed0a6b246f7865fb1c70d0fda66..c813479ba51c7d1c415e499550cf5f66e4493a5b 100644
--- a/chrome/browser/apps/app_view_browsertest.cc
+++ b/chrome/browser/apps/app_view_browsertest.cc
@@ -140,10 +140,10 @@ class AppViewTest : public extensions::PlatformAppBrowserTest {
};
// Tests that <appview> is able to navigate to another installed app.
-IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewBasic) {
+IN_PROC_BROWSER_TEST_F(AppViewTest, TestAppViewWithUndefinedDataShouldSucceed) {
const extensions::Extension* skeleton_app =
InstallPlatformApp("app_view/shim/skeleton");
- TestHelper("testAppViewBasic",
+ TestHelper("testAppViewWithUndefinedDataShouldSucceed",
"app_view/shim",
skeleton_app->id(),
NO_TEST_SERVER);
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/app_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698