Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/test/data/extensions/platform_apps/app_view/shim/main.js

Issue 464213005: Allow undefined data param to <appview>.connect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/app_view.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/app_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/app_view/shim/main.js b/chrome/test/data/extensions/platform_apps/app_view/shim/main.js
index 5b356a2d061d6d6dee98145108f83e67ad6758ff..f305dca2857c1923753ec82453c91a51a6701c6d 100644
--- a/chrome/test/data/extensions/platform_apps/app_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/app_view/shim/main.js
@@ -68,12 +68,12 @@ embedder.test.assertFalse = function(condition) {
};
// Tests begin.
-function testAppViewBasic(appToEmbed) {
+function testAppViewWithUndefinedDataShouldSucceed(appToEmbed) {
var appview = new AppView();
LOG('appToEmbed ' + appToEmbed);
// Step 1: Attempt to connect to a non-existant app.
LOG('attempting to connect to non-existant app.');
- appview.connect('abc123', {}, function(success) {
+ appview.connect('abc123', undefined, function(success) {
// Make sure we fail.
if (success) {
embedder.test.fail();
@@ -82,7 +82,7 @@ function testAppViewBasic(appToEmbed) {
LOG('failed to connect to non-existant app.');
LOG('attempting to connect to known app.');
// Step 2: Attempt to connect to an app we know exists.
- appview.connect(appToEmbed, {}, function(success) {
+ appview.connect(appToEmbed, undefined, function(success) {
// Make sure we don't fail.
if (!success) {
embedder.test.fail();
@@ -126,7 +126,8 @@ function testAppViewGoodDataShouldSucceed(appToEmbed) {
};
embedder.test.testList = {
- 'testAppViewBasic': testAppViewBasic,
+ 'testAppViewWithUndefinedDataShouldSucceed':
+ testAppViewWithUndefinedDataShouldSucceed,
'testAppViewRefusedDataShouldFail': testAppViewRefusedDataShouldFail,
'testAppViewGoodDataShouldSucceed': testAppViewGoodDataShouldSucceed
};
« no previous file with comments | « chrome/renderer/resources/extensions/app_view.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698