chrome/renderer/resources/extensions/app_view.js - Issue 464213005: Allow undefined data param to <appview>.connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/app_view.js

Issue 464213005: Allow undefined data param to <appview>.connect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/app_view.js

diff --git a/chrome/renderer/resources/extensions/app_view.js b/chrome/renderer/resources/extensions/app_view.js

index 7b48fe1d660ddda827ea4d2d7474ba061f967a54..968340b1f46a79271c6d924ffbe0680394507d3a 100644

--- a/chrome/renderer/resources/extensions/app_view.js

+++ b/chrome/renderer/resources/extensions/app_view.js

@@ -43,7 +43,7 @@ AppViewInternal.prototype.createBrowserPluginNode = function() {

AppViewInternal.prototype.connect = function(app, data, callback) {

var createParams = {

'appId': app,

- 'data': data

+ 'data': data || {}

};

var self = this;

GuestViewInternal.createGuest(