Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 46313003: Implement target visibility in GN (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Implement target visibility in GN This implements a visibility property for determining which targets can depend on a given target. The property works mostly like Blaze from the internal Google build, but replaces the magic public and private strings with wildcards, and defaults to public visibility. R=scottmg@chromium.org, scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260947

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : branch #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+590 lines, -6 lines) Patch
M tools/gn/BUILD.gn View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/builder.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/builder.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_gen.cc View 1 2 3 4 5 6 7 8 9 1 chunk +27 lines, -4 lines 0 comments Download
M tools/gn/function_toolchain.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/functions.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/item.h View 1 2 3 4 5 6 3 chunks +6 lines, -0 lines 0 comments Download
M tools/gn/target_generator.cc View 1 2 3 4 5 6 2 chunks +17 lines, -0 lines 0 comments Download
M tools/gn/variables.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 1 2 3 4 5 6 7 2 chunks +68 lines, -0 lines 0 comments Download
A tools/gn/visibility.h View 1 2 3 4 5 6 1 chunk +94 lines, -0 lines 0 comments Download
A tools/gn/visibility.cc View 1 2 3 4 5 6 7 8 1 chunk +259 lines, -0 lines 0 comments Download
A tools/gn/visibility_unittest.cc View 1 2 3 4 5 6 7 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Unfortunately this includes another pattern parser and matcher. This one is super simple at least. ...
6 years, 8 months ago (2014-03-28 21:06:47 UTC) #1
brettw
See how this is used: https://codereview.chromium.org/217273004/
6 years, 8 months ago (2014-03-28 21:08:46 UTC) #2
scottmg
lgtm, looks like it should useful to keep the browser/child DLLs separate on Windows. https://codereview.chromium.org/46313003/diff/190001/tools/gn/command_gen.cc ...
6 years, 8 months ago (2014-04-01 06:18:34 UTC) #3
brettw
6 years, 8 months ago (2014-04-01 21:45:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #10 manually as r260947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698