tools/gn/builder.cc - Issue 46313003: Implement target visibility in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/builder.cc

Issue 46313003: Implement target visibility in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/builder.cc

diff --git a/tools/gn/builder.cc b/tools/gn/builder.cc

index da8df5f77d7cb76f6e82226535b2395d490e1270..0f54893268dc4356360b4158b96c3abeb80a53fd 100644

--- a/tools/gn/builder.cc

+++ b/tools/gn/builder.cc

@@ -378,7 +378,7 @@ bool Builder::ResolveItem(BuilderRecord* record, Err* err) {

record->set_resolved(true);

record->item()->OnResolved();

if (!resolved_callback_.is_null())

- resolved_callback_.Run(record->item());

+ resolved_callback_.Run(record);

// Recursively update everybody waiting on this item to be resolved.

BuilderRecordSet& waiting_set = record->waiting_on_resolution();

« no previous file with comments | « tools/gn/builder.h ('k') | tools/gn/command_gen.cc » ('j') | no next file with comments »